Page MenuHomePhabricator
Create Task
Maniphest T254565

ArticlePlaceholder should use the SidebarBeforeOutput hook
Closed, ResolvedPublic
Actions

Description

This extension seems to be deployed on production and is using BaseTemplateToolbox hook

SidebarBeforeOutput should be used instead to add sidebar items.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/ArticlePlaceholdermaster+363 -363Use SidebarBeforeOutput hook to add items to sidebar toolbox
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ammarpad created this task.Jun 5 2020, 11:13 AM
Restricted Application added a project: Wikidata. · View Herald TranscriptJun 5 2020, 11:13 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Ammarpad added a parent task: T253416: Deprecate BaseTemplateToolbox hook.Jun 5 2020, 11:14 AM
Jdlrobson awarded a token.Jun 5 2020, 3:51 PM
Jdlrobson triaged this task as High priority.Jun 5 2020, 8:50 PM
gerritbot added a comment.Jun 8 2020, 5:59 AM

Change 603168 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/ArticlePlaceholder@master] WIP: Use SidebarBeforeOutput hook to add items to sidebar toolbox

https://gerrit.wikimedia.org/r/603168

gerritbot added a project: Patch-For-Review.Jun 8 2020, 5:59 AM
Ammarpad claimed this task.Jun 8 2020, 6:21 AM
Jdlrobson added a project: MediaWiki-Core-Skin-Architecture.Jun 8 2020, 11:07 PM
Jdlrobson moved this task from Backlog to Phase 1 - simplify hook contracts on the MediaWiki-Core-Skin-Architecture board.
Lydia_Pintscher added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).Jun 9 2020, 5:09 PM
Lydia_Pintscher moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Jun 9 2020, 5:15 PM
gerritbot added a comment.Jun 10 2020, 11:55 PM

Change 603168 merged by jenkins-bot:
[mediawiki/extensions/ArticlePlaceholder@master] Use SidebarBeforeOutput hook to add items to sidebar toolbox

https://gerrit.wikimedia.org/r/603168

Jdlrobson closed this task as Resolved.Jun 10 2020, 11:59 PM
Jdlrobson added a subscriber: Jdlrobson.

THANK YOU!

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.37; 2020-06-16).Jun 11 2020, 12:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jun 11 2020, 12:10 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL