API: removeFromToolbar doesn't work for buttons
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Schnark
	May 10 2010, 8:14 AM

Description

The API-function removeFromToolbar doesn't remove buttons: They are neither in div's nor do they have a "tool"-class, so the code target += ' div[rel=' + data.tool + '].tool'; can't find anything.

Version: unspecified
Severity: normal

Details

Reference: bz23457

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:10 PM

• bzimport added a project: MediaWiki-extensions-UsabilityInitiative.

• bzimport set Reference to bz23457.

Schnark created this task.May 10 2010, 8:14 AM

For the Wikieditor extension this bug got fixed in r74114. But it still exists in UsabilityInitiative/js/plugins/jquery.wikiEditor.toolbar.js

The fix was simple, it just needs to be backported...

r74788 (/branches/wmf/1.16wmf4/extensions/UsabilityInitiative/) and r74799 (/branches/REL1_16/extensions/UsabilityInitiative/) resolves this for deployment and release branches.

• Phabricator_maintenance added a project: WikiEditor.Jul 30 2016, 3:22 PM

• Phabricator_maintenance removed a parent task: T26493: [DO NOT USE] WikiEditor issues (tracking) [superseded by #WikiEditor].Jul 30 2016, 3:22 PM

happy5214 moved this task from Backlog to Closed on the WikiEditor board.Aug 4 2019, 11:37 AM

API: removeFromToolbar doesn't work for buttonsClosed, ResolvedPublicActions

Description

Details

Event Timeline

API: removeFromToolbar doesn't work for buttons
Closed, ResolvedPublic
Actions