Page MenuHomePhabricator

TwoColConflict & MonoBook: Icon on swap button broken
Closed, ResolvedPublic

Description

The swap button of the talk page version is somewhat brocken/misplaced in the MonoBook skin.

Bildschirmfoto zu 2020-06-05 14-59-17.png (234×375 px, 18 KB)

The reason is some custom padding we apply to the ..mw-twocolconflict-single-swap-button button via ext.TwoColConflict.Talk.styles.less. This should only be done in skins that use the default OOUI theme (named "WikimediaUI"), but not when the Apex theme is used, like it is in MonoBook.

For comparison, this is how the button should look like. Instead of just removing the padding it might be better to use a more generic or different padding in Apex based skins, so the button is (roughly) scaled to the same size in MonoBook.

Screenshot from 2022-05-18 11-23-26.png (119×354 px, 6 KB)


Instructions when working on the task:

If you need help along the way, feel free to poke @WMDE-Fisch

Event Timeline

Which exact Chromium version is this about? Also, any link where to see/test this?

Aklapper renamed this task from Icon brocken in Monobook to Icon broken in Monobook.Jun 5 2020, 8:40 PM
Jdlrobson edited projects, added MonoBook (Tracking); removed MonoBook.
thiemowmde renamed this task from Icon broken in Monobook to TwoColConflict & MonoBook: Icon on swap button broken.May 18 2022, 9:31 AM
thiemowmde added a project: good first task.
thiemowmde updated the task description. (Show Details)
thiemowmde added subscribers: thiemowmde, WMDE-Fisch.

Change 793000 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/TwoColConflict@master] Use more generic padding for swap button

https://gerrit.wikimedia.org/r/793000

Change 793000 merged by jenkins-bot:

[mediawiki/extensions/TwoColConflict@master] Use more generic padding for swap button

https://gerrit.wikimedia.org/r/793000

Tested again today. It might not be perfect but doesn't look as broken as in the screenshot above. Good enough for a skin with such a small user base.