Page MenuHomePhabricator

TwoColConflict & MinervaNeue: Misplaced info icon
Open, Needs TriagePublic

Description

When using the MinervaNeue skin (a.k.a. Mobile) there is no info icon to open the help popup, or the info icon is heavily misplaced.

As of 2020:

Bildschirmfoto zu 2020-06-05 15-17-36.png (1,107×468 px, 74 KB)

As of 2022:

Screenshot from 2022-05-18 11-06-24.png (1,036×422 px, 70 KB)

It looks like the reason is not the placement of the icon, but some misplaced form { width: 90%; } in the MinervaNeue CSS. This reduces the width of the form to 90% * 90% = 81%, while the icon is still placed at the right corner of a 90% wide rectangle. These 90% need to be removed/reset.

Here is a debug view that highlights the problem. The lower blue box should be as wide as the top blue box. The placement of the (i) icon on the right is actually correct.

Screenshot from 2022-05-18 11-09-42.png (1,168×449 px, 77 KB)


Instructions when working on the task:

If you need help along the way, feel free to poke @WMDE-Fisch

Event Timeline

Aklapper renamed this task from No info icon in minerva/mobil to No info icon in minerva/mobile.Jun 5 2020, 6:31 PM
thiemowmde renamed this task from No info icon in minerva/mobile to TwoColConflict & MinervaNeue: Misplaced info icon.May 18 2022, 9:12 AM
thiemowmde added a project: good first task.
thiemowmde updated the task description. (Show Details)
thiemowmde moved this task from Incoming to Backlog on the WMDE-TechWish-Maintenance board.

This seems to no longer be the case on desktop.

image.png (1,052×402 px, 66 KB)

On mobile however, the info icon is floating above the text.

image.png (356×259 px, 23 KB)

Change #1228508 had a related patch set uploaded (by Rehan_khan_78; author: Rehan_khan_78):

[mediawiki/extensions/TwoColConflict@master] Fix misplaced info icon in MinervaNeue skin

https://gerrit.wikimedia.org/r/1228508