Page MenuHomePhabricator

Implement button component
Closed, DuplicatePublic

Description

Component sizes:

Medium: Min-height: 32px
Large: Min-height: 40px

Component flavors:

  • Neutral
  • Primary progressive
  • Primary destructive

States per flavor:

  • Default
  • Hover
  • Focus
  • Active
  • Disabled

To be decided:

  • Align on whether we want to keep a 14px font size or a 16px (aligned with the WMF style guide) - To be validated with designers
  • Whether we agree to apply the following modifier options:

  • Should we include a "full width" modifier (T254729) or is "full-width button" its own component?
  • Is "button with icon" (T254599) a subclass of this component or, again, a modifier (knob)?

ACs:

  • The button follows the system's design specs
  • The button accommodates component-level design tokens (json file to be created)

Event Timeline

Restricted Application added a project: Wikidata. · View Herald TranscriptJun 5 2020, 3:14 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Sarai-WMDE updated the task description. (Show Details)Jun 5 2020, 3:16 PM
Sarai-WMDE updated the task description. (Show Details)Jun 5 2020, 3:39 PM
Sarai-WMDE renamed this task from Component: Button to Button component development.Jun 5 2020, 3:41 PM
Sarai-WMDE renamed this task from Button component development to Develop button component.
Sarai-WMDE updated the task description. (Show Details)
Sarai-WMDE updated the task description. (Show Details)Jun 5 2020, 4:03 PM
Sarai-WMDE renamed this task from Develop button component to Implement button component.Jun 8 2020, 9:23 AM
Sarai-WMDE updated the task description. (Show Details)Jun 8 2020, 9:48 AM
Sarai-WMDE updated the task description. (Show Details)Jun 8 2020, 9:56 AM
Sarai-WMDE updated the task description. (Show Details)Mon, Jul 6, 9:28 AM
Sarai-WMDE updated the task description. (Show Details)Thu, Jul 9, 5:02 PM