Page MenuHomePhabricator
Create Task
Maniphest T254610

Migrate Quibble from nose to pytest
Closed, ResolvedPublic
Actions

Description

Cause nose is obsolete and pytest is the latest trendy test runner.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Migrate from nose to pytestintegration/quibblemaster+17 -13
tests: singularize assertEquals to avoid warningintegration/quibblemaster+44 -44
tests: use coverage instead of nose coverage pluginintegration/quibblemaster+3 -2
tests: no more need to ignore test.pyintegration/quibblemaster+3 -3
Customize query in gerrit

Event Timeline

hashar created this task.Jun 5 2020, 5:07 PM
gerritbot added a comment.Jun 5 2020, 5:17 PM

Change 602743 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/quibble@master] tests: no more need to ignore test.py

https://gerrit.wikimedia.org/r/602743

gerritbot added a project: Patch-For-Review.Jun 5 2020, 5:17 PM
gerritbot added a comment.Jun 5 2020, 5:36 PM

Change 602746 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/quibble@master] Migrate from nose to pytest

https://gerrit.wikimedia.org/r/602746

hashar added a project: Technical-Debt.Jun 5 2020, 5:42 PM
gerritbot added a comment.Jun 5 2020, 5:43 PM

Change 602747 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/quibble@master] tests: pluralize assertEqual to avoid warning

https://gerrit.wikimedia.org/r/602747

gerritbot added a comment.Jun 5 2020, 5:57 PM

Change 602752 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/quibble@master] tests: use coverage instead of nose coverage plugin

https://gerrit.wikimedia.org/r/602752

hashar triaged this task as Medium priority.Jun 5 2020, 6:06 PM
hashar added a comment.Jun 5 2020, 6:11 PM

A little bit more than one hour to do the conversion. That is easier than expected!

gerritbot added a comment.Jun 8 2020, 4:29 PM

Change 602743 merged by jenkins-bot:
[integration/quibble@master] tests: no more need to ignore test.py

https://gerrit.wikimedia.org/r/602743

gerritbot added a comment.Jun 8 2020, 4:29 PM

Change 602747 merged by jenkins-bot:
[integration/quibble@master] tests: singularize assertEquals to avoid warning

https://gerrit.wikimedia.org/r/602747

gerritbot added a comment.Jun 8 2020, 4:33 PM

Change 602752 merged by jenkins-bot:
[integration/quibble@master] tests: use coverage instead of nose coverage plugin

https://gerrit.wikimedia.org/r/602752

gerritbot added a comment.Jun 8 2020, 4:33 PM

Change 602746 merged by jenkins-bot:
[integration/quibble@master] Migrate from nose to pytest

https://gerrit.wikimedia.org/r/602746

Maintenance_bot removed a project: Patch-For-Review.Jun 8 2020, 5:11 PM
hashar closed this task as Resolved.Jun 8 2020, 7:30 PM
hashar claimed this task.
hashar added a subscriber: awight.

The patch series has been reviewed and approved by @awight. Thank you Adam!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits