Page MenuHomePhabricator

Newcomer tasks: link targets for quick tips
Closed, ResolvedPublic

Description

For the "update article" task type, there are two different links used in the tips. In tip #5, there is a link label "add a reference" that should go to a help page about adding a reference. In tip #6, there is a link label "Learn more..." that should go to a help page about updating articles. Right now, they both go to the same help page about updating articles.

Also, we should make sure that if a wiki does not have a page about references, there should not be a link at all in tip #5. If a wiki does not have a page about adding links, the "Learn more..." text should not even be present in tip #6.

Event Timeline

Also, we should make sure that if a wiki does not have a page about references, there should not be a link at all in tip #5. If a wiki does not have a page about adding links, the "Learn more..." text should not even be present in tip #6.

This is already implemented, but if you are seeing different behavior please let me know. It's implemented such that if learnmore is defined in NewcomerTasks.json for a task type, we try to use it -- we do not verify that the learnmore title actually exists on the wiki, which is why you might see a red link in the beta wikis.

Change 603367 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Help panel tips: Pass all task type data into tip tree builder

https://gerrit.wikimedia.org/r/603367

Change 603368 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Help panel tips: Use references learn more link in step 5 for update

https://gerrit.wikimedia.org/r/603368

Change 603367 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Help panel tips: Pass all task type data into tip tree builder

https://gerrit.wikimedia.org/r/603367

Change 603510 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Fix links task type ID in LinkTipTree

https://gerrit.wikimedia.org/r/603510

Change 603368 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Help panel tips: Use references learn more link in step 5 for update

https://gerrit.wikimedia.org/r/603368

Change 603510 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Fix links task type ID in LinkTipTree

https://gerrit.wikimedia.org/r/603510

From the task description - enwiki betalabs "update article" tips have two links - Step 5 with "add reference" link leading to and Step 6 with a red link to a non existing in betalabs page, but in enwiki the page is - https://en.wikipedia.org/wiki/Wikipedia:As_of.

Tested in beta for the specific case - "update article"

  • current production (with the hidden preference) does not have "add reference" in Step 5 as a link -"Learn more" for the Step 6 is not present when a page does not exist
en betalabs
cswiki betalabs
arwiki betalabs
kowiki betalabs
  • (more generally) "Learn more" link will be present only if the relevant page does exists as per @kostajh comment.

Added the task to my post-deployment checklist.

@Urbanecm -- this is now in production, but I don't know if the behavior is as you expected. Could you please check it?

Links appear or do not appear as expected from design perspective depending on the existence of the links to additional information.

Urbanecm closed this task as Resolved.Jun 16 2020, 7:49 PM

@Urbanecm -- this is now in production, but I don't know if the behavior is as you expected. Could you please check it?

Looks good to me, thanks for the reminder. Thanks everyone! Closing, as it seems I'm the last one to review.