Unused timing/benchmarking in VideoTranscodeTest::runTranscodeJobs
Closed, ResolvedPublic
Actions

Description

VideoTranscodeTest::runTranscodeJobs has

				$t = microtime( true );
				$offset = $job->id;
				$status = $job->run();
				$t = microtime( true ) - $t;
				$timeMs = intval( $t * 1000 );

But it's not used for anything. Is it needed/wanted? Or should it just be removed?

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/TimedMediaHandler	master	+0 -3	Remove unused timing/benchmarking

Customize query in gerrit

Event Timeline

Reedy created this task.Jun 6 2020, 4:57 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 6 2020, 4:57 PM

Change 612628 had a related patch set uploaded (by Brion VIBBER; owner: Brion VIBBER):
[mediawiki/extensions/TimedMediaHandler@master] Remove unused timing/benchmarking

https://gerrit.wikimedia.org/r/612628

gerritbot added a project: Patch-For-Review.Jul 14 2020, 4:21 PM

brion moved this task from To sort to In progress on the TimedMediaHandler board.Jul 14 2020, 4:24 PM

Change 612628 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Remove unused timing/benchmarking

https://gerrit.wikimedia.org/r/612628

Maintenance_bot removed a project: Patch-For-Review.Jul 15 2020, 6:10 PM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.1; 2020-07-21).Jul 15 2020, 7:00 PM

merged and done.

Unused timing/benchmarking in VideoTranscodeTest::runTranscodeJobsClosed, ResolvedPublicActions

Description

Details

Event Timeline

Unused timing/benchmarking in VideoTranscodeTest::runTranscodeJobs
Closed, ResolvedPublic
Actions