Page MenuHomePhabricator

Unused timing/benchmarking in VideoTranscodeTest::runTranscodeJobs
Closed, ResolvedPublic

Description

VideoTranscodeTest::runTranscodeJobs has

				$t = microtime( true );
				$offset = $job->id;
				$status = $job->run();
				$t = microtime( true ) - $t;
				$timeMs = intval( $t * 1000 );

But it's not used for anything. Is it needed/wanted? Or should it just be removed?

Event Timeline

Change 612628 had a related patch set uploaded (by Brion VIBBER; owner: Brion VIBBER):
[mediawiki/extensions/TimedMediaHandler@master] Remove unused timing/benchmarking

https://gerrit.wikimedia.org/r/612628

Change 612628 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Remove unused timing/benchmarking

https://gerrit.wikimedia.org/r/612628

brion claimed this task.
brion added a subscriber: brion.

merged and done.