Page MenuHomePhabricator
Create Task
Maniphest T254676

Rename wgPopupsPageBlacklist
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Popups has a config flag called wgPopupsPageBlacklist
wgPopupsPageDisabled would be a better choice of name
To make this transition smoother, rely on the fact that the config in production is set across all projects and simply change its default value to:

'Special:CreateAccount',
'Special:GlobalRenameRequest',
'Special:Userlogin',
'Special:MergeAccount',
'Special:ChangeCredentials',
'Special:OAuthListConsumers',
'Special:GlobalUserRights',
'Special:Notifications',
'Special:UserRights',
'Special:Upload',
'Special:VipsTest',
'Special:ApiFeatureUsage',
'Special:ExpandTemplates',
'Special:GadgetUsage',
'Special:GraphSandbox',
'Special:TemplateSandbox',
'Special:MostLinkedFiles',
'Special:Book',

a/c

  • Rename isTitleBlacklisted in Popups extension
  • Rename config flag PopupsPageBlacklist to wgPopupsPageDisabled using the default value
  • Remove associated site config

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove wgPopupsPageBlacklist config settingoperations/mediawiki-configmaster+0 -23
Popups: Rename new config variablemediawiki/extensions/Popupsmaster+22 -5
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedNoneT254646 Reconsidering how we name things
 ResolvedJdlrobsonT254676 Rename wgPopupsPageBlacklist

Event Timeline

Jdlrobson created this task.Jun 6 2020, 11:22 PM
Jdlrobson added a project: Web-Team-Backlog-Archived.Jun 8 2020, 6:20 PM
ovasileva triaged this task as Medium priority.Jun 9 2020, 3:41 PM
ovasileva edited projects, added Web-Team-Backlog-Archived (Kanbanana-2019-20-Q4); removed Web-Team-Backlog-Archived.
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog-Archived (Kanbanana-2019-20-Q4) board.Jun 10 2020, 5:23 PM
ovasileva set the point value for this task to 2.Jul 1 2020, 4:39 PM
ovasileva moved this task from Upcoming to Ready for Development on the Web-Team-Backlog-Archived (Kanbanana-2019-20-Q4) board.Jul 1 2020, 5:25 PM
Ammarpad claimed this task.Jul 2 2020, 10:02 PM
Ammarpad subscribed.

The method has already been fixed by Thiemo in r603808. So only the config variable remains. But I am not sure about the third point...

Remove associated site config

After renaming it, also remove it?

Jdlrobson added a comment.Jul 3 2020, 12:46 AM

If the default value is changed there is no need to override it in mediawiki config. This means we don't have to worry about changing the config prior to changing the name of the config variable and after changing it we can remove the override in the operations/mediawiki-config repo. Does that make sense?

Ammarpad added a comment.Jul 3 2020, 8:25 AM

OK, it's clear now. And that simplifies this a lot, because otherwise changing it in operations/mediawiki-config repo cannot be done in single patch.

gerritbot added a comment.Jul 3 2020, 8:26 AM

Change 609391 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/Popups@master] Popups: Add new config variable

https://gerrit.wikimedia.org/r/609391

gerritbot added a project: Patch-For-Review.Jul 3 2020, 8:26 AM
Jdlrobson moved this task from Ready for Development to Needs Code Review on the Web-Team-Backlog-Archived (Kanbanana-2019-20-Q4) board.Jul 6 2020, 5:25 PM
Jdlrobson moved this task from Needs Code Review to Needs More Work on the Web-Team-Backlog-Archived (Kanbanana-2019-20-Q4) board.Jul 6 2020, 6:15 PM
Jdlrobson moved this task from Needs More Work to Needs Code Review on the Web-Team-Backlog-Archived (Kanbanana-2019-20-Q4) board.Jul 7 2020, 5:08 PM
gerritbot added a comment.Jul 7 2020, 9:29 PM

Change 609391 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Popups: Rename new config variable

https://gerrit.wikimedia.org/r/609391

Jdlrobson moved this task from Needs Code Review to Blocked on Others on the Web-Team-Backlog-Archived (Kanbanana-2019-20-Q4) board.Jul 7 2020, 9:48 PM

Blocked until 16th 4pm PST when we can clean up the mediawiki-config

Jdlrobson updated the task description. (Show Details)Jul 7 2020, 9:48 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.41; 2020-07-14).Jul 7 2020, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 7 2020, 10:10 PM
MBinder_WMF edited projects, added Web-Team-Backlog-Archived (Kanbanana-FY-2020-21); removed Web-Team-Backlog-Archived (Kanbanana-2019-20-Q4).Jul 9 2020, 5:21 PM
MBinder_WMF moved this task from Needs Analysis to Blocked on Others on the Web-Team-Backlog-Archived (Kanbanana-FY-2020-21) board.Jul 9 2020, 5:21 PM
Jdlrobson moved this task from Blocked on Others to Doing on the Web-Team-Backlog-Archived (Kanbanana-FY-2020-21) board.Jul 15 2020, 5:06 PM
Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog-Archived (Kanbanana-FY-2020-21) board.Jul 17 2020, 4:34 PM
gerritbot added a comment.Jul 17 2020, 7:15 PM

Change 613684 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[operations/mediawiki-config@master] Remove wgPopupsPageBlacklist config setting

https://gerrit.wikimedia.org/r/613684

gerritbot added a project: Patch-For-Review.Jul 17 2020, 7:15 PM
gerritbot added a comment.Jul 20 2020, 11:28 AM

Change 613684 merged by jenkins-bot:
[operations/mediawiki-config@master] Remove wgPopupsPageBlacklist config setting

https://gerrit.wikimedia.org/r/613684

Stashbot added a comment.Jul 20 2020, 11:36 AM

Mentioned in SAL (#wikimedia-operations) [2020-07-20T11:36:18Z] <urbanecm@deploy1001> Synchronized wmf-config/InitialiseSettings.php: c12f1dee6b9888849c64312c2a4fd65ecbd4091e: Remove wgPopupsPageBlacklist config setting (T254676) (duration: 00m 57s)

Maintenance_bot removed a project: Patch-For-Review.Jul 20 2020, 12:11 PM
Jdlrobson moved this task from Code Review to Ready for Signoff on the Web-Team-Backlog-Archived (Kanbanana-FY-2020-21) board.Jul 20 2020, 3:59 PM
Jdlrobson added a subscriber: Urbanecm.

Thank you @Ammarpad and @Urbanecm for taking care of the deploy!

Ammarpad updated the task description. (Show Details)Jul 25 2020, 6:04 AM
Jdlrobson claimed this task.Jul 27 2020, 5:07 PM

ill sign off

Jdlrobson closed this task as Resolved.Jul 27 2020, 6:34 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits