Hard deprecate Revision::getContent
Closed, ResolvedPublic
Actions

Description

There are a number of methods with the same name, making searching for existing uses hard. That being said, I believe the only remaining uses are:

(EntitySchema) EntitySchemaContentHandler::getUndoContent - only when Revision objects are passed, which is deprecated and doesn't occur in production
(WikiBase) EntityHandler::getUndoContent - only when Revision objects are passed, which is deprecated and doesn't occur in production
(Translate) TranslateEditAddons::displayOnDiff - only when DifferenceEngine::getNewRevision isn't callable, i.e. for previous versions on mediawiki, not an issue in production
(Core) ContentHandler::getUndoContent - only when Revision objects are passed, which is deprecated and doesn't occur in production
(Core) RevisionStoreDbTestBase
(Core) RevisionDbTest
(Core) RevisionTest
(Core) ApiRevisionDeleteTest
(Core) WikiPageDbTest

Thus, I believe that we can hard deprecate the method. If I missed any of the uses, there would be some logspam, but no code should break. Once the deprecation is merged, I'll leave a note on the blockers task for the week with a heads-up

Details

	Subject	Repo	Branch	Lines +/-
	Hard deprecate Revision::getContent	mediawiki/core	master	+37 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T11968 Reduce use of global and public variables
Open	None	T159283 Deprecate non-configuration globals
Open	DannyS712	T159299 Deprecate and remove $wgUser
Resolved	DannyS712	T267861 [GOAL] Emit deprecation warnings reading from $wgUser
Open	DannyS712	T243708 Mediawiki core needs uses of global $wgUser removed
Resolved	DannyS712	T246284 Hard deprecate the Revision class
Resolved	DannyS712	T251067 Hard deprecate individual Revision class methods [tracking]
Resolved	DannyS712	T254703 Hard deprecate Revision::getContent