Page MenuHomePhabricator

Remove Revision::newFromId
Closed, ResolvedPublic

Description

Deprecated in 1.35, has remaining callers to remove

Event Timeline

DannyS712 changed the task status from Open to Stalled.Jun 8 2020, 2:52 AM
DannyS712 triaged this task as Medium priority.
DannyS712 created this task.
DannyS712 moved this task from Unsorted to Later on the User-DannyS712 board.

Cannot be removed until 1.36

Change 603099 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/BlueSpiceFoundation@master] BSExtendedApiContext: Remove use of Revision::newFromId

https://gerrit.wikimedia.org/r/603099

DannyS712 changed the task status from Stalled to Open.Jul 18 2020, 9:50 AM

Change 631564 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] SuggestedEdits: Fix footer display

https://gerrit.wikimedia.org/r/631564

Change 631564 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] SuggestedEdits: Fix footer display

https://gerrit.wikimedia.org/r/631564

Sorry, this patch is unrelated. It was posted here because I typo-ed the task number.

Change 631564 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] SuggestedEdits: Fix footer display

https://gerrit.wikimedia.org/r/631564

DannyS712 changed the task status from Open to Stalled.Dec 29 2020, 9:02 PM

Reflect decision to wait until 1.37 for Revision removals

DannyS712 claimed this task.

This task was filed when I was not expecting to be able to remove the whole Revision class, sorry for the confusion. Resolving now that the entire class has been removed as part of T247143, see rMW983984d5d4a4: EPIC: Remove the Revision class entirely.