Page MenuHomePhabricator

Remove whitelist/blacklist in Parsoid
Closed, ResolvedPublic

Description

Use better/more descriptive terms.

Event Timeline

cscott created this task.Jun 8 2020, 6:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 8 2020, 6:58 PM

Change 603574 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/services/parsoid@master] Rename 'TagWhiteList'

https://gerrit.wikimedia.org/r/603574

Change 603578 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/services/parsoid@master] Rename WikiLinkHandler::isWhitelistedOpt

https://gerrit.wikimedia.org/r/603578

Change 603580 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/services/parsoid@master] Replace a few occurences of "whitelist" in comments w/ more appropriate terms

https://gerrit.wikimedia.org/r/603580

Change 603581 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/services/parsoid@master] Fix an incorrect 'whitelist' in XMLSerializer

https://gerrit.wikimedia.org/r/603581

Change 603574 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Rename 'TagWhiteList'

https://gerrit.wikimedia.org/r/603574

Change 603578 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Rename WikiLinkHandler::isWhitelistedOpt

https://gerrit.wikimedia.org/r/603578

ssastry assigned this task to cscott.Jun 8 2020, 7:43 PM
ssastry triaged this task as Medium priority.

Change 603580 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Replace a few occurences of "whitelist" in comments w/ more appropriate terms

https://gerrit.wikimedia.org/r/603580

Change 603581 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Fix an incorrect 'whitelist' in XMLSerializer

https://gerrit.wikimedia.org/r/603581

Change 603599 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/services/parsoid@master] Fix an incorrect 'whitelist' in XMLSerializerTest

https://gerrit.wikimedia.org/r/603599

cscott added a comment.Jun 8 2020, 8:36 PM

FYI: @Arlolra already submitted https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/602518 and I merged it last week.

Excellent! Thanks, @Arlolra.

It appears that the remaining work here is in Sanitizer, which I'd like to fix upstream first (since our code is an incomplete/extended copy of upstream) and T75581: Parsoid doesn't support image allow/deny configuration, which I'd like to fix via T254802: Make the external image block list / allow list into an extension if I can -- that is, if I'm going to be deprecating a bunch of old names for config variables and functions anyway, I think I might as well move that code out of core in a way which lets Parsoid use it (via a new clean hook with a new clean name) at the same time.

Change 603599 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Fix an incorrect 'whitelist' in XMLSerializerTest

https://gerrit.wikimedia.org/r/603599

Change 603610 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/services/parsoid@master] Remove one more reference to 'whitelist', this time in a parserTest comment

https://gerrit.wikimedia.org/r/603610

Change 603610 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Remove one more reference to 'whitelist', this time in a parserTest comment

https://gerrit.wikimedia.org/r/603610

ssastry moved this task from Needs Triage to Backlog on the Parsoid board.Jun 9 2020, 10:32 PM

Change 605678 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/vendor@master] Bump Parsoid to 0.12.0-a17

https://gerrit.wikimedia.org/r/605678

Change 605678 merged by jenkins-bot:
[mediawiki/vendor@master] Bump Parsoid to 0.12.0-a17

https://gerrit.wikimedia.org/r/605678

cscott closed this task as Resolved.Mon, Nov 16, 5:54 PM