Page MenuHomePhabricator

Bad diff display breaking RevisionSlider browser tests
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT

Description

Something's wrong with the diff display:

image.png (888×1 px, 126 KB)

It's possible that this is a test-only issue, but superficially it seems to be an edge case that might be reachable from production. The bottom pane should be a preview of the latest revision, but instead it seems to be a diff between older revisions, probably related to a special order of clicking around the interface.

The gray "loading"-state diff breaks several tests which are waiting for the loading style to go away.

Event Timeline

I just noted that it seems that the broken browser tests are at least partly related to the wdio v6 update. - Other recent patches just worked fine and had no problems getting merged with passing tests.

See https://gerrit.wikimedia.org/r/606751 or https://gerrit.wikimedia.org/r/607393

zeljkofilipin claimed this task.

The failing ruby tests got fixed somehow. 🤷‍♂️ This is no longer failing.