Page MenuHomePhabricator

Bad diff display breaking RevisionSlider browser tests
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT

Description

Something's wrong with the diff display:


It's possible that this is a test-only issue, but superficially it seems to be an edge case that might be reachable from production. The bottom pane should be a preview of the latest revision, but instead it seems to be a diff between older revisions, probably related to a special order of clicking around the interface.

The gray "loading"-state diff breaks several tests which are waiting for the loading style to go away.

Event Timeline

awight created this task.Jun 8 2020, 8:09 PM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptJun 8 2020, 8:09 PM
zeljkofilipin moved this task from Backlog 🔙 to Waiting... 🐌 on the User-zeljkofilipin board.

This is blocking all merges in RevisionSlider, including @Vidhi-Mody's patch 602758.

zeljkofilipin triaged this task as High priority.Jun 15 2020, 10:30 AM
Lena_WMDE set the point value for this task to 3.Jun 24 2020, 8:30 AM

I just noted that it seems that the broken browser tests are at least partly related to the wdio v6 update. - Other recent patches just worked fine and had no problems getting merged with passing tests.

See https://gerrit.wikimedia.org/r/606751 or https://gerrit.wikimedia.org/r/607393

zeljkofilipin closed this task as Resolved.Jun 25 2020, 5:08 PM
zeljkofilipin claimed this task.

The failing ruby tests got fixed somehow. 🤷‍♂️ This is no longer failing.