Page MenuHomePhabricator
Create Task
Maniphest T254827

Use SpecialInvestigate::getTabParam when building a URL
Closed, ResolvedPublic
Actions

Description

URLs to particular tabs on Special:Investigate can be built using getTabParam and getTabName, since the URL param and tab name are the same (discussed in T253823#6204129).

However, it's more correct to use getTabParam. This also makes it easier to decouple the URL param and tab name in the future, if necessary.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/CheckUsermaster+6 -5SpecialInvestigate: Use getTabParam to build URLs
mediawiki/extensions/CheckUsermaster+6 -5SpecialInvestigate: Use getTabParam to build URLs
Customize query in gerrit

Related Objects

Event Timeline

Tchanders created this task.Jun 8 2020, 10:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 8 2020, 10:23 PM
gerritbot added a comment.Jun 8 2020, 10:24 PM

Change 603642 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/CheckUser@master] SpecialInvestigate: Use getTabParam to build URLs

https://gerrit.wikimedia.org/r/603642

gerritbot added a project: Patch-For-Review.Jun 8 2020, 10:24 PM
gerritbot added a comment.Jun 8 2020, 10:26 PM

Change 602745 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/CheckUser@master] SpecialInvestigate: Use getTabParam to build URLs

https://gerrit.wikimedia.org/r/602745

gerritbot added a comment.Jun 8 2020, 10:27 PM

Change 603642 abandoned by Tchanders:
SpecialInvestigate: Use getTabParam to build URLs

Reason:
Duplicate of Ic17dce362b899bfeb10988e5486cca2ef3d4ac54

https://gerrit.wikimedia.org/r/603642

Tchanders claimed this task.Jun 9 2020, 2:33 PM
Tchanders moved this task from In Progress to Code Review on the Anti-Harassment (The Letter Song) board.
Tchanders moved this task from Code Review to Done: Q4 (2019-20) on the Anti-Harassment (The Letter Song) board.Jun 9 2020, 3:34 PM
gerritbot added a comment.Jun 9 2020, 3:49 PM

Change 602745 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] SpecialInvestigate: Use getTabParam to build URLs

https://gerrit.wikimedia.org/r/602745

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.36; 2020-06-09).Jun 9 2020, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 9 2020, 4:10 PM
Niharika closed this task as Resolved.Jul 31 2020, 9:44 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL