Page MenuHomePhabricator

Newcomer tasks: exclude article that was just edited from post-edit suggestions
Closed, ResolvedPublic

Description

Per T245790#6203701, we should exclude the article that a user just edited from the pool of articles to be suggested in the post-edit dialog. We should do this even if it's the only possible article, and instead show the "no suggestions" content.

Event Timeline

Tgr claimed this task.Jun 11 2020, 3:05 PM

Change 604775 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Newcomer tasks: exclude article that was just edited from post-edit suggestions

https://gerrit.wikimedia.org/r/604775

Change 604775 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Newcomer tasks: exclude article that was just edited from post-edit suggestions

https://gerrit.wikimedia.org/r/604775

Works as expected and the phab task T245790 was updated accordingly.

Moved for @MMiller_WMF review with a question - should we handle the following scenario?

  • a user has only few articles returned in SE - say, only two
  • a user makes an edit on the first one out of two articles and in the post-edit dialog sees the second article, clicks to edit it
  • after saving an edit, the post-edit dialog will suggest to edit the first article again
MMiller_WMF closed this task as Resolved.Jun 16 2020, 7:46 PM

This is working fine. Thank you! @Etonkovidova -- I do not think we need special handling for the case you described. I think that would require more work than worthwhile to address it.