Page MenuHomePhabricator

GlobalBlocking.php: PHP Notice: Trying to get property 'gb_expiry' of non-object
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error message
ErrorException from line 132 of /srv/mediawiki/php-1.35.0-wmf.35/extensions/GlobalBlocking/includes/GlobalBlocking.php: PHP Notice: Trying to get property 'gb_timestamp' of non-object 

ErrorException from line 135 of /srv/mediawiki/php-1.35.0-wmf.35/extensions/GlobalBlocking/includes/GlobalBlocking.php: PHP Notice: Trying to get property 'gb_expiry' of non-object 
ErrorException from line 136 of /srv/mediawiki/php-1.35.0-wmf.35/extensions/GlobalBlocking/includes/GlobalBlocking.php: PHP Notice: Trying to get property 'gb_by_wiki' of non-object 

ErrorException from line 137 of /srv/mediawiki/php-1.35.0-wmf.35/extensions/GlobalBlocking/includes/GlobalBlocking.php: PHP Notice: Trying to get property 'gb_by_wiki' of non-object 
ErrorException from line 137 of /srv/mediawiki/php-1.35.0-wmf.35/extensions/GlobalBlocking/includes/GlobalBlocking.php: PHP Notice: Trying to get property 'gb_by' of non-object
Stack Trace
#0 /srv/mediawiki/php-1.35.0-wmf.35/extensions/GlobalBlocking/includes/GlobalBlocking.php(148): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.35.0-wmf.35/extensions/GlobalBlocking/includes/GlobalBlocking.php(54): GlobalBlocking::getUserBlockDetails(User, string)
#2 /srv/mediawiki/php-1.35.0-wmf.35/extensions/GlobalBlocking/includes/GlobalBlockingHooks.php(94): GlobalBlocking::getUserBlockErrors(User, string)
#3 /srv/mediawiki/php-1.35.0-wmf.35/includes/HookContainer/HookContainer.php(318): GlobalBlockingHooks::onGetUserPermissionsErrorsExpensive(Title, User, string, string)
#4 /srv/mediawiki/php-1.35.0-wmf.35/includes/HookContainer/HookContainer.php(130): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#5 /srv/mediawiki/php-1.35.0-wmf.35/includes/HookContainer/HookRunner.php(1975): MediaWiki\HookContainer\HookContainer->run(string, array)
#6 /srv/mediawiki/php-1.35.0-wmf.35/includes/Permissions/PermissionManager.php(459): MediaWiki\HookContainer\HookRunner->onGetUserPermissionsErrorsExpensive(Title, User, string, string)
#7 /srv/mediawiki/php-1.35.0-wmf.35/includes/Permissions/PermissionManager.php(409): MediaWiki\Permissions\PermissionManager->checkPermissionHooks(string, User, array, string, boolean, Title)
#8 /srv/mediawiki/php-1.35.0-wmf.35/includes/Permissions/PermissionManager.php(289): MediaWiki\Permissions\PermissionManager->getPermissionErrorsInternal(string, User, Title, string)
#9 /srv/mediawiki/php-1.35.0-wmf.35/includes/EditPage.php(773): MediaWiki\Permissions\PermissionManager->getPermissionErrors(string, User, Title, string)
#10 /srv/mediawiki/php-1.35.0-wmf.35/includes/EditPage.php(669): EditPage->getEditPermissionErrors(string)
#11 /srv/mediawiki/php-1.35.0-wmf.35/includes/actions/EditAction.php(59): EditPage->edit()
#12 /srv/mediawiki/php-1.35.0-wmf.35/includes/MediaWiki.php(521): EditAction->show()
#13 /srv/mediawiki/php-1.35.0-wmf.35/includes/MediaWiki.php(307): MediaWiki->performAction(Article, Title)
#14 /srv/mediawiki/php-1.35.0-wmf.35/includes/MediaWiki.php(980): MediaWiki->performRequest()
#15 /srv/mediawiki/php-1.35.0-wmf.35/includes/MediaWiki.php(537): MediaWiki->main()
#16 /srv/mediawiki/php-1.35.0-wmf.35/index.php(47): MediaWiki->run()
Impact
Notes

See also: T179741: ApiGlobalBlock.php: Trying to get property 'gb_expiry' or 'gb_anon_only ' of non-object

Event Timeline

Looks like there is no maintainers specified on mediawiki.org. Recent commits also don't show anyone in particular who's active here.
This is probably an easy fix. Perhaps CPT could take a look while we continue to look for a steward.

Change 604514 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/GlobalBlocking@master] Check for block in GlobalBlocking::getUserBlockDetails

https://gerrit.wikimedia.org/r/604514

Change 604514 merged by jenkins-bot:
[mediawiki/extensions/GlobalBlocking@master] Check for block in GlobalBlocking::getUserBlockDetails

https://gerrit.wikimedia.org/r/604514

Change 604849 had a related patch set uploaded (by Krinkle; owner: Umherirrender):
[mediawiki/extensions/GlobalBlocking@wmf/1.35.0-wmf.36] Check for block in GlobalBlocking::getUserBlockDetails

https://gerrit.wikimedia.org/r/604849

Change 604849 abandoned by Jforrester:
Check for block in GlobalBlocking::getUserBlockDetails

Reason:
All prod is now running wmf.37.

https://gerrit.wikimedia.org/r/604849