Page MenuHomePhabricator

Hard deprecate Revision::getSize
Closed, ResolvedPublic

Description

Lots of methods by that name, so finding remaining uses will be hard.
https://codesearch.wmflabs.org/deployed/?q=-%3EgetSize%5C(%5C)&i=nope&files=&repos=

There are a number of methods with the same name, making searching for existing uses hard. That being said, I believe the only remaining uses are:

  • RevisionStoreDbTestBase
  • RevisionDbTest
  • RevisionTest

Thus, I believe that we can hard deprecate the method. If I missed any of the uses, there would be some logspam, but no code should break. Once the deprecation is merged, I'll leave a note on the blockers task for the week with a heads-up

Event Timeline

DannyS712 triaged this task as Medium priority.Jun 10 2020, 5:09 AM
DannyS712 created this task.
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.
DannyS712 updated the task description. (Show Details)

Change 604242 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate Revision::getSize

https://gerrit.wikimedia.org/r/604242

Tried searching in IDE with the vast majority of extensions checked out, had the same result. In case something was missed, having some deprecation warnings is not the end of the world.

Change 604242 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate Revision::getSize

https://gerrit.wikimedia.org/r/604242