Hard deprecate Revision::getTimestamp
Closed, ResolvedPublic
Actions

Description

Lots of methods by the same name; looking for remaining uses now

https://codesearch.wmflabs.org/deployed/?q=-%3EgetTimestamp%5C(%5C)&i=nope&files=&repos=

Remaining deployed uses:

Details

Subject	Repo	Branch	Lines +/-
Hard deprecate Revision::getTimestamp	mediawiki/core	master	+20 -1
WikiPage::updateIfNewerOn - don't call Revision::getTimestamp	mediawiki/core	master	+9 -4
CategoryMembershipChange: Don't call Revision::getTimestamp	mediawiki/core	master	+6 -7

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T11968 Reduce use of global and public variables
Open	None	T159283 Deprecate non-configuration globals
Open	DannyS712	T159299 Deprecate and remove $wgUser
Resolved	DannyS712	T267861 [GOAL] Emit deprecation warnings reading from $wgUser
Open	DannyS712	T243708 Mediawiki core needs uses of global $wgUser removed
Resolved	DannyS712	T246284 Hard deprecate the Revision class
Resolved	DannyS712	T251067 Hard deprecate individual Revision class methods [tracking]
Resolved	DannyS712	T254966 Hard deprecate Revision::getTimestamp

Event Timeline

DannyS712 triaged this task as Medium priority.Jun 10 2020, 5:30 AM

DannyS712 created this task.

DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.

DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.

DannyS712 claimed this task.Jun 10 2020, 5:41 AM

DannyS712 updated the task description. (Show Details)

Change 604244 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] CategoryMembershipChange: Don't call Revision::getTimestamp

https://gerrit.wikimedia.org/r/604244

gerritbot added a project: Patch-For-Review.Jun 10 2020, 5:42 AM

Change 604246 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] WikiPage::updateIfNewerOn - don't call Revision::getTimestamp

https://gerrit.wikimedia.org/r/604246

Change 604244 merged by jenkins-bot:
[mediawiki/core@master] CategoryMembershipChange: Don't call Revision::getTimestamp

https://gerrit.wikimedia.org/r/604244

Change 604246 merged by jenkins-bot:
[mediawiki/core@master] WikiPage::updateIfNewerOn - don't call Revision::getTimestamp

https://gerrit.wikimedia.org/r/604246

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.37; 2020-06-16).Jun 10 2020, 3:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 10 2020, 3:10 PM

DannyS712 updated the task description. (Show Details)Jun 10 2020, 4:48 PM

Change 604446 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate Revision::getTimestamp

https://gerrit.wikimedia.org/r/604446

gerritbot added a project: Patch-For-Review.Jun 10 2020, 4:52 PM

DannyS712 updated the task description. (Show Details)Jun 10 2020, 4:57 PM