Page MenuHomePhabricator

Hard deprecate Revision::getTimestamp
Closed, ResolvedPublic

Description

Lots of methods by the same name; looking for remaining uses now

https://codesearch.wmflabs.org/deployed/?q=-%3EgetTimestamp%5C(%5C)&i=nope&files=&repos=

Remaining deployed uses:

  • CategoryMembershipChange::__construct
  • WikiPage::updateIfNewerOn
  • RevisionDbTest
  • RevisionTest
  • PageArchiveTest
  • WikiPageDbTest
  • RevisionStoreDbTestBase

Event Timeline

DannyS712 triaged this task as Medium priority.Jun 10 2020, 5:30 AM
DannyS712 created this task.
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.
DannyS712 updated the task description. (Show Details)

Change 604244 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] CategoryMembershipChange: Don't call Revision::getTimestamp

https://gerrit.wikimedia.org/r/604244

Change 604246 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] WikiPage::updateIfNewerOn - don't call Revision::getTimestamp

https://gerrit.wikimedia.org/r/604246

Change 604244 merged by jenkins-bot:
[mediawiki/core@master] CategoryMembershipChange: Don't call Revision::getTimestamp

https://gerrit.wikimedia.org/r/604244

Change 604246 merged by jenkins-bot:
[mediawiki/core@master] WikiPage::updateIfNewerOn - don't call Revision::getTimestamp

https://gerrit.wikimedia.org/r/604246

DannyS712 updated the task description. (Show Details)Jun 10 2020, 4:48 PM

Change 604446 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate Revision::getTimestamp

https://gerrit.wikimedia.org/r/604446

DannyS712 updated the task description. (Show Details)Jun 10 2020, 4:57 PM

Change 604446 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate Revision::getTimestamp

https://gerrit.wikimedia.org/r/604446