Page MenuHomePhabricator
Create Task
Maniphest T254974

Make TwoColConflict browser tests compatible with enabled QuickSurveys
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Do Not Track support will be removed from the QuickSurveys T254224: Remove Do Not Track support for QuickSurveys. We currently use DNT to disable QuickSurveys in the Two-Column-Edit-Conflict-Merge browser tests to avoid irritations in the selenium dailies run on beta labs. See T251235: QuickSurveys on Beta messes with TwoColConflict selenium dailys.

WIth DNT removed we would probably need another way to avoid these irritations assuming that QuickSurveys will still pop up randomly on the beta labs servers.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Test literal wikitextAwightmediawiki/extensions/TwoColConflictmaster+34 -14
Customize query in gerrit

Related Objects

Event Timeline

WMDE-Fisch created this task.Jun 10 2020, 9:03 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 10 2020, 9:03 AM
WMDE-Fisch updated the task description. (Show Details)Jun 10 2020, 9:03 AM
Lena_WMDE added a project: WMDE-QWERTY-Sprint-2020-06-10.Jun 10 2020, 11:45 AM
Lena_WMDE set the point value for this task to 2.
awight claimed this task.Jun 10 2020, 1:13 PM
awight moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2020-06-10 board.
gerritbot added a comment.Jun 10 2020, 2:40 PM

Change 604408 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/TwoColConflict@master] Test literal wikitext

https://gerrit.wikimedia.org/r/604408

gerritbot added a project: Patch-For-Review.Jun 10 2020, 2:40 PM
awight renamed this task from Find a way to disable QuickSurveys in browser tests without using DNT to Make TwoColConflict browser tests compatible with enabled QuickSurveys.Jun 10 2020, 2:41 PM
awight moved this task from Doing to Review on the WMDE-QWERTY-Sprint-2020-06-10 board.
gerritbot added a comment.Jun 11 2020, 1:40 PM

Change 604408 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Test literal wikitext

https://gerrit.wikimedia.org/r/604408

WMDE-Fisch moved this task from Review to Demo on the WMDE-QWERTY-Sprint-2020-06-10 board.Jun 11 2020, 1:46 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.37; 2020-06-16).Jun 11 2020, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 11 2020, 2:10 PM
Jdlrobson added a project: Web-Team-Backlog-Archived (Tracking).Jun 11 2020, 8:53 PM
awight moved this task from Not triaged to Configuration on the QuickSurveys board.Jun 19 2020, 8:02 AM
Lena_WMDE moved this task from Backlog to Tickets in sprint on the Two-Column-Edit-Conflict-Merge board.Jun 22 2020, 1:45 PM
awight closed this task as Resolved.Jun 23 2020, 11:41 AM
awight moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2020-06-10 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits