Author: nickweiss
Description:
I'm not sure if this belongs in Lucene or here, but with the new search system, if typing a search entry and hitting enter quickly, only part of the search field will be sent, "Harrier" is desired, and I am redirected to "Har" if more time is taken to type and hit enter, the system works fine, but if typing quickly, this bug occurs.
Version: unspecified
Severity: critical
riffraffselbow wrote:
Also encountered on Windows on Firefox; others have reported on Village Pump (Technical) that they encountered it on Chrome, so it looks more or less universal. My best guess is that it has something to do with the search suggestions. If that's the case, recommend a temporary disable until it's fixed, as this is absolutely a dealbreaker from my point-of-view.
rainman wrote:
Bumping up this to a major bug. Hundreds of people are affected by this bug every second and it prevents them from getting to the page they want to get to. Please make it top priority to solve it.
gamepro777 wrote:
Also reporting this bug. Getting irritating that the box/search cannot keep up with fast typers. Typically searches based on what you had typed in when it began to suggest searches.
ian.woollard wrote:
Something like 50% of the article hits go through this search box (the rest go through google). The importance of this bug cannot be overstated. We're looking at millions of people affected.
rainman wrote:
If the issues cannot be resolved today, it might be best just to temporarily disable SimpleSearch, as the commons vector-tested old search seemed to have worked fine.
delbu9c1 wrote:
Confirming the issue here. It really seems to me like it's not actually a performance issue, but rather that it's caused by the delay from querying the server for suggestions. A possible guess is that it's capturing the first few keys, sending a request, then more keys are typed and the user pushes "enter" before a response is received, and the contents that triggered the initial request are what is taken.
But I haven't looked into the code for this, that is just what it feels like based on experimental usage.
(In reply to comment #8)
If the issues cannot be resolved today, it might be best just to temporarily
disable SimpleSearch, as the commons vector-tested old search seemed to have
worked fine.
Since this is not realistically going to be fixed over the weekend, I've gone ahead and done exactly this. The JS part of SimpleSearch has been disabled until we sort out this issue. The search bar still looks the same, and mwsuggest has taken over the AJAX search suggestions.
tore wrote:
(In reply to comment #10)
Since this is not realistically going to be fixed over the weekend, I've gone
ahead and done exactly this. The JS part of SimpleSearch has been disabled
until we sort out this issue. The search bar still looks the same, and
mwsuggest has taken over the AJAX search suggestions.
FYI, I just checked and the bug is still present.
tore wrote:
Expanding on my previous comment: it seems like the bug now appears less frequently, but it is still possible to get it if you type very quickly and press enter immediately after typing. Either letters will disappear from the end of the search string, or you will be taken to the search page as if you didn't type anything at all. It does seem like you need to type faster than before in order to get it though.
ian.woollard wrote:
Is this commons or wikipedia Tore?
The bug seems to be not present currently on the English Wikipedia for me using the latest release of Firefox.
I just realized that the way I disabled SimpleSearch meant it wouldn't be disabled for anonymous users immediately due to caching. I have now fixed this.
gamepro777 wrote:
Tested this morning, confirming that it is still an issue. Using IE8, English Wikipedia, last few characters of search still being trimmed as the suggested search area shows up under.
ayg wrote:
Confirmed, this is still present for me on enwiki. Both logged in and logged out, including with cleared cache.
amiller1 wrote:
Fixed in r66565. We'll test it a little more and try to get the fix deployed as soon as possible.
(In reply to comment #17)
Yes, bug is back now on English wikipedia using firefox.
I thought I had disabled SimpleSearch properly this time around, but it looks like I still hadn't. I got Domas to purge the JS in Varnish; clearing your browser cache or doing a hard refresh (Ctrl+F5 in most browsers) should disable SimpleSearch for real.