Page MenuHomePhabricator
Create Task
Maniphest T255049

Deprecate sequential array parameter to Sanitizer::validateAttributes
Closed, ResolvedPublic
Actions

Description

We need to flip the parameter to validateAttributes in order to efficiently do the membership test, so let's just ask our callers to give us the parameter in the format we need in the first place.

Details

SubjectRepoBranchLines +/-
Hard-deprecate sequential array as parameter to Sanitizer::validateAttributesmediawiki/coremaster+8 -4
Pass associative array to Sanitizer::validateAttributesmediawiki/extensions/Listingsmaster+2 -2
Pass associative array to Sanitizer::validateAttributesmediawiki/extensions/EtherpadLitemaster+6 -2
Pass associative array to Sanitizer::validateAttributesmediawiki/extensions/SyntaxHighlight_GeSHimaster+4 -2
Customize query in gerrit

Related Objects

Event Timeline

cscott created this task.Jun 10 2020, 5:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 10 2020, 5:47 PM
gerritbot added a comment.Jun 10 2020, 5:57 PM

Change 604464 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/EtherpadLite@master] Pass associative array to Sanitizer::validateAttributes

https://gerrit.wikimedia.org/r/604464

gerritbot added a project: Patch-For-Review.Jun 10 2020, 5:57 PM
gerritbot added a comment.Jun 10 2020, 5:59 PM

Change 604465 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/Listings@master] Pass associative array to Sanitizer::validateAttributes

https://gerrit.wikimedia.org/r/604465

gerritbot added a comment.Jun 10 2020, 6:02 PM

Change 604466 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Pass associative array to Sanitizer::validateAttributes

https://gerrit.wikimedia.org/r/604466

gerritbot added a comment.Jun 10 2020, 6:04 PM

Change 604467 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Hard-deprecate sequential array as parameter to Sanitizer::validateAttribute

https://gerrit.wikimedia.org/r/604467

gerritbot added a comment.Jun 12 2020, 2:44 AM

Change 604466 merged by jenkins-bot:
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Pass associative array to Sanitizer::validateAttributes

https://gerrit.wikimedia.org/r/604466

cscott mentioned this in rESHGc281e5f423c8: Pass associative array to Sanitizer::validateAttributes.Jun 12 2020, 2:50 AM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.37; 2020-06-16).Jun 12 2020, 3:00 AM
gerritbot added a comment.Jun 15 2020, 12:30 PM

Change 604464 merged by jenkins-bot:
[mediawiki/extensions/EtherpadLite@master] Pass associative array to Sanitizer::validateAttributes

https://gerrit.wikimedia.org/r/604464

gerritbot added a comment.Jun 15 2020, 12:30 PM

Change 604465 merged by jenkins-bot:
[mediawiki/extensions/Listings@master] Pass associative array to Sanitizer::validateAttributes

https://gerrit.wikimedia.org/r/604465

gerritbot added a comment.Jun 15 2020, 12:31 PM

Change 604467 merged by jenkins-bot:
[mediawiki/core@master] Hard-deprecate sequential array as parameter to Sanitizer::validateAttributes

https://gerrit.wikimedia.org/r/604467

Maintenance_bot removed a project: Patch-For-Review.Jun 15 2020, 1:10 PM
Jdforrester-WMF closed this task as Resolved.Jun 15 2020, 1:48 PM
Jdforrester-WMF assigned this task to cscott.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL