[Regression] Preview not visible in source mode
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• ppelberg
	Jun 11 2020, 12:22 AM

Description

The preview in the Reply tool's source mode is not visible.

Behavior

Visit: https://en.wikipedia.beta.wmflabs.org/wiki/Talk:Cats
Click any "Reply" link
Switch to the tool's source mode if you are not already in it
Start typing a comment (it doesn't matter what it includes)

Expected

✅ Notice a preview of the comment you are drafting appears below the text input

Actual

❗️Notice a preview of the comment you are drafting DOES NOT appears below the text input [i]

i. Preview not appearing

Details

	Subject	Repo	Branch	Lines +/-
	Follow-up Icb14766: Fix formatversion:2 param	mediawiki/extensions/DiscussionTools	master	+5 -6

Customize query in gerrit

Related Objects

Mentioned Here: rEDTO0cfc84aa2917: Always use API formatversion: 2

Event Timeline

• ppelberg created this task.Jun 11 2020, 12:22 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 11 2020, 12:22 AM

• ppelberg triaged this task as High priority.Jun 11 2020, 12:23 AM

• ppelberg moved this task from Needs Prioritization to Required for Release on the OWC2020 (OWC2020 Replying 2.0) board.

• ppelberg moved this task from Needs Discussion / Investigation to Ready for Development on the Editing-team (Q3 2019-2020 Kanban Board) board.

JJMC89 added a project: Regression.Jun 11 2020, 12:32 AM

I think the API response changed?

We do:

widget.$preview.html( response ? response.parse.text : '' );

...but the response content is such that response.parse.text['*'] would be needed.

@Esanders suggests that this might be an issue with 0cfc84aa29177025f34998d412e02692f47d5d67 not actually working.

Change 604804 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/DiscussionTools@master] Follow-up Icb14766: Fix formatversion:2 param

https://gerrit.wikimedia.org/r/604804

gerritbot added a project: Patch-For-Review.Jun 11 2020, 5:28 PM

Esanders raised the priority of this task from High to Unbreak Now!.Jun 11 2020, 5:28 PM

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptJun 11 2020, 5:28 PM

We should backport this.

Change 604804 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Follow-up Icb14766: Fix formatversion:2 param

https://gerrit.wikimedia.org/r/604804

Esanders moved this task from Code Review to QA on the Editing-team (Q3 2019-2020 Kanban Board) board.Jun 11 2020, 5:46 PM

In T255083#6216227, @Esanders wrote:

We should backport this.

Turns out the original bug (https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/DiscussionTools/+/602183/) was merged just after the cut, so no backport necessary.

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.37; 2020-06-16).Jun 11 2020, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 11 2020, 6:10 PM

• ppelberg added a project: Editing QA.Jun 15 2020, 9:31 PM

• ppelberg edited projects, added Skipped QA; removed Editing QA.

The source mode's preview is available on https://en.wikipedia.beta.wmflabs.org/wiki/Talk:Cats:

Screen Shot 2020-06-15 at 2.34.24 PM.png (586×1 px, 71 KB)

	F31867217: Screen Shot 2020-06-15 at 2.34.24 PM.png
	Jun 15 2020, 9:34 PM

	F31860742: Screen Shot 2020-06-10 at 5.22.28 PM.png
	Jun 11 2020, 12:22 AM

[Regression] Preview not visible in source modeClosed, ResolvedPublicActions