Page MenuHomePhabricator

Align timestamps when watchlist is grouped by pages
Closed, ResolvedPublic

Description

Align the timestamps in the watchlist when it is grouped by pages. The best and most consistent way of doing this is adding the watch/unwatch message as a hidden element.

CurrentExpected
image.png (152×254 px, 8 KB)
image.png (160×254 px, 8 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 604546 had a related patch set uploaded (by BrandonXLF; owner: BrandonXLF):
[mediawiki/core@master] watchlist: Always insert unwatch text instead of nothing

https://gerrit.wikimedia.org/r/604546

@BrandonXLF, When I tested this back in June,I was able to reproduce the bug in master and confirmed the fix in r604546 worked. Now, I cannot reproduce the bug on master, and I am not sure what fixed it or how. Can you confirm the bug is still present on wiki and preferably give clear steps to reproduce?

@Ammarpad I can still reproduce it no problem.

On English Wikipedia:

  1. Watch User:BrandonXLF/sandbox/4‎‎
  2. Make sure the "Add direct unwatch/watch markers (×/+) to watched pages with change option" (watchlistunwatchlinks) is enabled
  3. Make sure "Group results by page" is enabled

On dev wiki:

  1. Move Page A to Page B
  2. Move Page B to Page A
  3. Repeat steps 1 and 2
  4. Edit Page A twice
  5. Watch Page A
  6. Make sure the "Add direct unwatch/watch markers (×/+) to watched pages with change option" (watchlistunwatchlinks) is enabled
  7. Make sure "Group results by page" is enabled

Change 604546 merged by jenkins-bot:
[mediawiki/core@master] watchlist: Always insert unwatch text instead of nothing

https://gerrit.wikimedia.org/r/604546

Ammarpad assigned this task to BrandonXLF.

FYI, I missed the part about enabling 'enhancedrc'. It's not explicit in the repro steps.