Page MenuHomePhabricator

Tests failing for the master branch of Flow
Closed, ResolvedPublic

Description

Tests are currently failing for the master branch for Flow

https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Flow/+/604552/ is an empty patch with only a commit message but it is failing tests

22:11:20 <checkstyle version="6.5">
22:11:20   <file name="maintenance/FlowUpdateResolvedNotifTitles.php">
22:11:20     <error line="90" severity="error" message="Call to undeclared method \MWEchoDbFactory::waitForSlaves" source="PhanUndeclaredMethod"/>
22:11:20   </file>
22:11:20 </checkstyle>

Likely cause: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Echo/+/603703/ as part of T254646: Reconsidering how we name things

Event Timeline

Restricted Application added projects: Growth-Team, User-DannyS712. · View Herald TranscriptJun 11 2020, 5:14 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 604553 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Flow@master] FlowUpdateResolvedNotifTitles: Update MWEchoDbFactory::waitForReplicas

https://gerrit.wikimedia.org/r/604553

DannyS712 triaged this task as High priority.Jun 11 2020, 5:16 AM
DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.

Change 604553 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] FlowUpdateResolvedNotifTitles: Update MWEchoDbFactory::waitForReplicas

https://gerrit.wikimedia.org/r/604553

DannyS712 closed this task as Resolved.Jun 11 2020, 6:40 AM
DannyS712 removed a project: Patch-For-Review.