Page MenuHomePhabricator

Use WikibaseDataModelTypes instead of local Wikibase data model TS definitions
Closed, InvalidPublic

Description

Since June 2020 there is a centralized place for TypeScript interfaces and other definitions for general Wikibase code (e. g. Statement, Snak) - WikibaseDataModelTypes
Use that (published on npm under @wmde/wikibase-datamodel-types ) instead of the definitions in src/definitions/wikibase-js-datamodel.
If something is missing, please feel free to send pull requests to the GitHub repo for other data (value) types.

Note: This package is already consumed in Data Bridge. See https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/599902

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptThu, Jun 11, 1:21 PM
guergana.tzatchkova closed this task as Invalid.Tue, Jun 30, 3:17 PM

Tainted References is not using the types available at @wmde/wikibase-datamodel-types

Tainted References is not using the types available at @wmde/wikibase-datamodel-types

Do you mean Tained Refs cannot use them for some reason?
The task is to make Tainted Refs use @wmde/wikibase-datamodel-type

Tainted refs is just plainly not depending on that datamodel at all. I also did not anticipate that when I suggested that task for onboarding. All their types are about the methods on the existing frontend "data-model" and there is just nothing about the actual data structures in their code.

Tainted refs is just plainly not depending on that datamodel at all. I also did not anticipate that when I suggested that task for onboarding. All their types are about the methods on the existing frontend "data-model" and there is just nothing about the actual data structures in their code.

My understanding was that some data model values can still be useful to tainted refs. Arguably, that does imply a bit more involvement with the code base.
While this is deemed not a good onboarding task, I think we should at least ask @Tarrow (and other members of that hike) if this task is invalid, before closing it.