Page MenuHomePhabricator

Deleted file revision appears in the patrol queue
Open, Needs TriagePublic

Description

I found this issue on a MediaWiki 1.32.5 wiki. When a file revision is deleted before it was patrolled, it shows up in the patrol queue, and is difficult to mark as patrolled.

How to reproduce

  1. Upload a file and a file revision with a non-autopatrol account
  2. Delete the first file revision
  3. Go to the patrol queue (Special:RecentChanges with the "Unpatrolled" filter selected)

Expected result

The deleted file revision is not in the patrol queue. No action needed.

Actual result

The deleted file revision is in the patrol queue. It is difficult to patrol it, because the [Mark as patrolled] button is not available.

Temporary workaround

  1. Obtain the rcid of the change with something like https://examplewiki.org/w/api.php?action=query&list=recentchanges&rcprop=timestamp|title|ids&rcshow=!patrolled&rclimit=100
  2. Then mark it as patrolled with https://examplewiki.org/w/index.php?action=markpatrolled&rcid=12345 (replacing 12345 with the actual rcid).

Event Timeline

DannyS712 subscribed.

Unfortunately, mediawiki 1.32 is no longer supported (it stopped being supported in January 2020). If this can be reproduced with a supported version of mediawiki (see https://www.mediawiki.org/wiki/Version_lifecycle) please reopen the task and update the description accordingly.

Reproducible and in the newest versions, description and steps for reproducing are exactly the same.

Per my previous comment.

Here to report the same problem, but for unpatrolled files with a single revision. If left unpatrolled, then deleted, the file still shows in recent changes as unpatrolled, and API returns it in the list of unpatrolled changes. All delete actions (files, pages) should mark all unpatrolled changes as patrolled; what's the point of having to patrol something that no longer exists?