SkinAfterPortletHandlerTest: failing CI for non-English wikis
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Pablo-WMDE
	Jun 12 2020, 7:57 AM

Description

1) Wikibase\Client\Tests\Unit\Hooks\SkinAfterPortletHandlerTest::testDoSkinAfterPortlet_editLink

Failed asserting that '<span class="wb-langlinks-edit wb-langlinks-link"><a href="http://www.example.com/wiki/Special:EntityPage/Q2013#sitelinks-wikipedia" title="تحرير الروابط ما بين اللغات" class="wbc-editpage">عدل الوصلات</a></span>' contains "Edit links".

https://travis-ci.org/github/wikimedia/mediawiki-extensions-Wikibase/builds/697395007

Code was recently touched in
https://gerrit.wikimedia.org/r/603543

Details

	Subject	Repo	Branch	Lines +/-
	Fix test to work in any language	mediawiki/extensions/Wikibase	master	+2 -2

Customize query in gerrit

Event Timeline

• Pablo-WMDE created this task.Jun 12 2020, 7:57 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 12 2020, 7:57 AM

Upping this. master can't be red.

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptJun 12 2020, 8:02 AM

RhinosF1 subscribed.Jun 12 2020, 8:04 AM

darthmon_wmde subscribed.Jun 12 2020, 9:22 AM

Michael claimed this task.Jun 12 2020, 9:23 AM

Restricted Application added a project: User-Michael. · View Herald TranscriptJun 12 2020, 9:23 AM

Change 605200 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] Fix test to work in any language

https://gerrit.wikimedia.org/r/605200

gerritbot added a project: Patch-For-Review.Jun 12 2020, 12:41 PM

Michael added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).Jun 12 2020, 12:52 PM

Michael moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Change 605200 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix test to work in any language

https://gerrit.wikimedia.org/r/605200

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Jun 12 2020, 1:15 PM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.37; 2020-06-16).Jun 12 2020, 2:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 12 2020, 2:10 PM

Travis seems green again. Is there anything left to do for this? @Pablo-WMDE

Ammarpad awarded a token.Jun 12 2020, 2:34 PM

I confirm that the last 3 master builds were green and given we filed this for us I guess we can also call it. Solved. Thanks!

• Pablo-WMDE moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jun 12 2020, 3:05 PM

SkinAfterPortletHandlerTest: failing CI for non-English wikisClosed, ResolvedPublicActions

Description

Details

Event Timeline

SkinAfterPortletHandlerTest: failing CI for non-English wikis
Closed, ResolvedPublic
Actions