Page MenuHomePhabricator

SkinAfterPortletHandlerTest: failing CI for non-English wikis
Closed, ResolvedPublic

Description

1) Wikibase\Client\Tests\Unit\Hooks\SkinAfterPortletHandlerTest::testDoSkinAfterPortlet_editLink

Failed asserting that '<span class="wb-langlinks-edit wb-langlinks-link"><a href="http://www.example.com/wiki/Special:EntityPage/Q2013#sitelinks-wikipedia" title="تحرير الروابط ما بين اللغات" class="wbc-editpage">عدل الوصلات</a></span>' contains "Edit links".

https://travis-ci.org/github/wikimedia/mediawiki-extensions-Wikibase/builds/697395007

Code was recently touched in
https://gerrit.wikimedia.org/r/603543

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 12 2020, 7:57 AM
Pablo-WMDE triaged this task as Unbreak Now! priority.Jun 12 2020, 8:02 AM

Upping this. master can't be red.

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptJun 12 2020, 8:02 AM
Michael claimed this task.Jun 12 2020, 9:23 AM
Restricted Application added a project: User-Michael. · View Herald TranscriptJun 12 2020, 9:23 AM

Change 605200 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] Fix test to work in any language

https://gerrit.wikimedia.org/r/605200

Change 605200 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix test to work in any language

https://gerrit.wikimedia.org/r/605200

Michael lowered the priority of this task from Unbreak Now! to High.Jun 12 2020, 2:31 PM

Travis seems green again. Is there anything left to do for this? @Pablo-WMDE

Pablo-WMDE closed this task as Resolved.Jun 12 2020, 3:01 PM

I confirm that the last 3 master builds were green and given we filed this for us I guess we can also call it. Solved. Thanks!