Change 8fb998ba makes generate_family_file.py return exit code 1
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Dvorapa
	Jun 12 2020, 8:12 AM

Description

...even when it might generate family file successfully.

https://travis-ci.org/github/wikimedia/pywikibot/jobs/697281670#L408

Related Objects

Mentioned Here: T252310: pywikibot get merge rejections due to zuul-merger not being able to update tags

Event Timeline

Dvorapa created this task.Jun 12 2020, 8:12 AM

Restricted Application added a project: Pywikibot. · View Herald TranscriptJun 12 2020, 8:12 AM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald Transcript

I created revert (https://gerrit.wikimedia.org/r/#/c/pywikibot/core/+/604926/), but it can't be merged possibly due to T252310

Dvorapa moved this task from Backlog to CI test failures on the Pywikibot-tests board.Jun 12 2020, 8:17 AM

Any idea why this breaking happens?

I think I've localized the problem:
generate_family_file.py is called with pwb.py wrapper for musicbrainz (whereas for other sites generate_family_file.py is called directly. Normally pwb.py imports pywikibot which imports config.py which expects user-config.py. The direct call of generate_family_file .py uses _import_with_no_user_config. If pwb.py is used it expects RuntimeError in line 219 and set 'PYWIKIBOT_NO_USER_CONFIG' to 2. it does not generate_user_files if generate_family_file.py is running.

Xqt triaged this task as High priority.Jun 13 2020, 9:42 AM

Xqt closed this task as Resolved.Jun 13 2020, 10:16 AM

Xqt claimed this task.

Xqt reassigned this task from Xqt to Dvorapa.Jun 13 2020, 3:17 PM

Change 8fb998ba makes generate_family_file.py return exit code 1Closed, ResolvedPublicActions

Description

Related Objects

Event Timeline

Change 8fb998ba makes generate_family_file.py return exit code 1
Closed, ResolvedPublic
Actions