Page MenuHomePhabricator

Require HTTPS for external survey link
Open, Needs TriagePublic

Description

It looks like this was intended to become the default, but never quite implemented fully. Some code to support this validation is still present but commented out. Let's enforce the HTTPS requirement in SurveyFactory.

I've uploaded a tentative patch, but will wait for Readers Web approval in case there's some reason we still want to support http survey links.

Event Timeline

Change 605285 had a related patch set uploaded (by Awight; owner: Awight):
[operations/mediawiki-config@master] Remove unused field

https://gerrit.wikimedia.org/r/605285

Change 605285 merged by jenkins-bot:
[operations/mediawiki-config@master] Remove unused field

https://gerrit.wikimedia.org/r/605285

Change 605296 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/QuickSurveys@master] [DNM] Enforce external surveys are HTTPS

https://gerrit.wikimedia.org/r/605296