In the 'IPs and User agents' tab, the results are grouped and sorted by cuc_user_text, cuc_ip, cuc_agent. The use of cuc_ip leads to incorrect sorting:
We should instead use cuc_ip_hex.
Description
Description
Details
Details
Related Changes in Gerrit:
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T139810 RFC: Overhaul the CheckUser extension | |||
| Resolved | Niharika | T236225 [Epic] CheckUser 2.0 Improvements | |||
| Resolved | Niharika | T237593 [Epic] CheckUser 2.0: Compare | |||
| Resolved | Tchanders | T237300 CU 2.0: Sorting in the Compare tab | |||
| Resolved | Tchanders | T255312 Sort results by cuc_ip_hex in Special:Investigate |
Event Timeline
Comment Actions
Change 605318 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/CheckUser@master] Sort Special:Investigate results by cuc_ip_hex instead of cuc_ip
Comment Actions
I generally try to stay away from CU 2.0 tasks but I want to point out that some of the development on it, including this task, may conflict with T233004
Comment Actions
Change 605318 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Sort Special:Investigate results by cuc_ip_hex instead of cuc_ip
Comment Actions
I created some test data on my local vagrant (MediaWiki 1.35.0-alpha (c0a0483)).
- Every IP in the range 192.168.121.0/24
- A sample of IPs from the range 192.168.0.0/16.
- Random IPv6 address from lots of different ranges.
I checked the sorting for the initial sorting order, and after clicking the header to sort ascending and descending.
(For IPv6 I only checked initial sorting order, as the asc/desc will be fixed in T255694.)
They all appear in the correct order (i.e. numerical order).
Example of the now correct initial sorting (compare to the screenshot in the description):
Example from IPv6. 2001:df0:8b:6a1:225c:3a92:cacd:b6c3 now correctly comes before 2001:df0:8b:5c4d:9f4e:741d:ebc8:f374, because the former is implicitly 2001:df0:8b:06a1:225c:3a92:cacd:b6c3:
