Page MenuHomePhabricator

Remove the deprecated MonoBookAfterToolbox hook
Closed, ResolvedPublic

Description

The MonoBookAfterToolbox hook is interchangeable now with the SkinAfterPortlet hook provided the $portlet parameter is checked against tb.

We should be able to remove the hook in 1.35 release and provide a patch for ShoutWiki, its only known consumer.

https://codesearch.wmflabs.org/search/?q=MonoBookAfterToolbox&i=nope&files=&repos=

acceptance criteria

  • A shoutwiki patch exists
  • Remove it from Modern
  • Remove it from Monobook

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 12 2020, 9:18 PM
Ammarpad triaged this task as Medium priority.
Ammarpad updated the task description. (Show Details)

Change 607023 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/ShoutWikiAds@master] Use SkinAfterPortlet hook to add toolbox ad

https://gerrit.wikimedia.org/r/607023

Change 607027 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/skins/MonoBook@master] Drop MonoBookAfterToolbox hook

https://gerrit.wikimedia.org/r/607027

Change 607029 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/skins/Modern@master] Drop MonoBookAfterToolbox hook

https://gerrit.wikimedia.org/r/607029

Change 607023 merged by jenkins-bot:
[mediawiki/extensions/ShoutWikiAds@master] Use SkinAfterPortlet hook to add toolbox ad

https://gerrit.wikimedia.org/r/607023

Change 607027 merged by jenkins-bot:
[mediawiki/skins/MonoBook@master] Drop MonoBookAfterToolbox hook

https://gerrit.wikimedia.org/r/607027

Change 607029 merged by jenkins-bot:
[mediawiki/skins/Modern@master] Drop MonoBookAfterToolbox hook

https://gerrit.wikimedia.org/r/607029

Ammarpad closed this task as Resolved.Jun 26 2020, 2:34 PM
Ammarpad updated the task description. (Show Details)