Adyen audit processor does not import initial recurring donations
Closed, ResolvedPublic
Actions

Description

There was just a fail mail from the audit trying to bring in a missing recurring donation

INVALID_MESSAGE Recurring donation, but no subscription ID or recurring payment token found.

Contribution tracking id: 80667778

Details

	Subject	Repo	Branch	Lines +/-
	Fix Adyen audit processor recur handling	wikimedia/fundraising/crm	master	+39 -0
	Add token creation to message import if token exists.	wikimedia/fundraising/crm	master	+45 -1

Customize query in gerrit

Related Objects

Mentioned In: T248420: Paypal recurring payments missing predecessor
T257707: Q1 FY 20/21 epic for Q2 readiness

Event Timeline

Cstone created this task.Jun 12 2020, 9:24 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 12 2020, 9:24 PM

• DStrine moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.Jun 15 2020, 8:03 PM

• DStrine moved this task from Sprint +1 to FR-Ops on the Fundraising-Backlog board.Jun 18 2020, 5:03 PM

• DStrine moved this task from FR-Ops to Q3 2021-2022 on the Fundraising-Backlog board.Jun 23 2020, 5:32 PM

• DStrine moved this task from Q3 2021-2022 to Sprint +3 on the Fundraising-Backlog board.

• DStrine mentioned this in T257707: Q1 FY 20/21 epic for Q2 readiness .Jul 10 2020, 8:56 PM

• DStrine added a project: FR-Q2-FY2020-21-cleanup-list.Jul 20 2020, 10:36 PM

• DStrine moved this task from Sprint +3 to Sprint +2 on the Fundraising-Backlog board.Jul 21 2020, 3:01 PM

Cstone mentioned this in T248420: Paypal recurring payments missing predecessor.Jul 22 2020, 3:44 PM

• DStrine moved this task from Sprint +2 to Current Sprint on the Fundraising-Backlog board.Aug 4 2020, 8:04 PM

• DStrine added a project: Fundraising Sprint Pseudopretzels.Aug 4 2020, 8:58 PM

• DStrine triaged this task as Medium priority.Aug 4 2020, 9:02 PM

Cstone claimed this task.Aug 11 2020, 9:03 PM

Cstone moved this task from Backlog to Doing on the Fundraising Sprint Pseudopretzels board.Aug 11 2020, 11:34 PM

• DStrine added a project: fundraising Sprint Quackery limited to ducks.Aug 18 2020, 8:59 PM

Cstone moved this task from Backlog to Doing on the fundraising Sprint Quackery limited to ducks board.Aug 19 2020, 2:57 AM

Another example: 82430062.1

The recurring is set up properly in Adyen with a token but the token was not inserted into civicrm_payment_token.

Cstone renamed this task from Recurring Donations from Adyen Audit to Adyen audit processor does not import initial recurring donations.Sep 1 2020, 7:49 PM

• DStrine added a project: Fundraising Sprint Raw data never hurt anyone.Sep 1 2020, 8:30 PM

Change 623668 had a related patch set uploaded (by Eileen; owner: Eileen):
[wikimedia/fundraising/crm@master] Fix Adyen audit processor recur handling

https://gerrit.wikimedia.org/r/623668

gerritbot added a project: Patch-For-Review.Sep 2 2020, 1:03 AM

So it turns out we filter acceptable variables from the json when retrieving from the log https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/623668/1/sites/all/modules/wmf_audit/BaseAuditProcessor.php

Cstone moved this task from Backlog to Review on the Fundraising Sprint Raw data never hurt anyone board.Sep 2 2020, 4:17 PM

Change 624922 had a related patch set uploaded (by Cstone; owner: Cstone):
[wikimedia/fundraising/crm@master] WIP: Add token creation to message import if token exists.

https://gerrit.wikimedia.org/r/624922

@Cstone I think we should merge this too before calling this 'done'

https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/623668

Change 624922 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Add token creation to message import if token exists.

https://gerrit.wikimedia.org/r/624922

Cstone moved this task from Review to Pending Deployment on the Fundraising Sprint Raw data never hurt anyone board.Sep 15 2020, 7:12 PM

Change 623668 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Fix Adyen audit processor recur handling

https://gerrit.wikimedia.org/r/623668

Maintenance_bot removed a project: Patch-For-Review.Sep 15 2020, 8:10 PM

• DStrine added a project: Fundraising Sprint 🐍 is not a valid zipcode.Sep 15 2020, 8:45 PM

Cstone moved this task from Backlog to Pending Deployment on the Fundraising Sprint 🐍 is not a valid zipcode board.Sep 16 2020, 2:04 AM

@Cstone I think this is merged?