Page MenuHomePhabricator

Eventually deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universal
Open, LowPublic

Description

NOTE: low priority. Just wanted to capture this somewhere and start the conversation given the many extensions that use these.

https://codesearch.wmcloud.org/search/?q=SkinTemplateNavigation%3A%3ASpecialPage&i=nope&files=&excludeFiles=&repos=
https://codesearch.wmcloud.org/search/?q=SkinTemplateNavigation%22%3A&i=nope&files=&excludeFiles=&repos=

Every time the SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks are run we also run the SkinTemplateNavigation::Universal hook. The latter is always run based on the current page. We could just run the latter and get rid of 2 needless hooks.

Proposal:

Having 3 hooks doing pretty much the same thing seems gratutious. I would suggest standardizing on SkinTemplateNavigation::Universal and for the hooks themselves to do the required checks they need. I am however open to keeping all three after hearing from the current extensions using these hooks (tagged) and benefits they see in having three of them.

The SkinTemplateNavigation hook is deprecated in favor of SkinTemplateNavigation::Universal . It's up to callers to check whether the title exists if they care.
The SkinTemplateNavigation::SpecialPage is deprecated in favor of SkinTemplateNavigation::Universal. Callers must use $skin->getTitle() to check whether the page is a special page

Fixed

Extensions/skins that are fixed are listed here and have been untagged.

  • Vector
  • FileExporter
  • QuizGame
  • PictureGame
  • BlueSpice
  • NSFileRepo
  • FlaggedRevs
  • AdvancedMeta
  • TimedMediaHandler
  • Newsletter
  • TinyMCE

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Newslettermaster+2 -2
mediawiki/extensions/BlueSpicePageAssignmentsmaster+5 -5
mediawiki/extensions/BlueSpicePageAssignmentsREL1_35+5 -5
mediawiki/extensions/TimedMediaHandlermaster+1 -1
mediawiki/extensions/AdvancedMetamaster+9 -9
mediawiki/extensions/AdvancedMetaREL1_35+9 -9
mediawiki/extensions/FlaggedRevsREL1_35+2 -2
mediawiki/extensions/BlueSpiceRemindermaster+5 -5
mediawiki/extensions/BlueSpiceExpirymaster+6 -13
mediawiki/extensions/FlaggedRevsmaster+2 -2
mediawiki/extensions/NSFileRepoREL1_35+2 -2
mediawiki/extensions/NSFileRepomaster+2 -2
mediawiki/extensions/BlueSpiceReadersmaster+8 -5
mediawiki/extensions/BlueSpiceInsertCategorymaster+7 -6
mediawiki/extensions/BlueSpiceBookshelfmaster+5 -5
mediawiki/extensions/BlueSpiceReadersREL1_35+8 -5
mediawiki/extensions/BlueSpiceExpiryREL1_35+6 -13
mediawiki/extensions/BlueSpiceInsertCategoryREL1_35+7 -6
mediawiki/extensions/BlueSpiceBookshelfREL1_35+5 -5
mediawiki/extensions/BlueSpiceReminderREL1_35+5 -5
mediawiki/skins/Vectormaster+5 -2
mediawiki/extensions/FileExportermaster+62 -45
mediawiki/extensions/QuizGamemaster+6 -4
mediawiki/extensions/PictureGamemaster+3 -3
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

It's done for MediaWiki-extensions-LinkedWiki (see commits in the new extensions: PushAll and NamescpaceData)

Change 605830 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileExporter@master] Stop using the SkinTemplateNavigation::SpecialPage hook in favor of the SkinTemplateNavigation::Universal hook

https://gerrit.wikimedia.org/r/605830

Change 605361 merged by jenkins-bot:
[mediawiki/extensions/PictureGame@master] Stop using the SkinTemplateNavigation::SpecialPage hook in favor of the SkinTemplateNavigation::Universal hook

https://gerrit.wikimedia.org/r/605361

Change 605362 merged by jenkins-bot:
[mediawiki/extensions/QuizGame@master] Stop using the SkinTemplateNavigation::SpecialPage hook in favor of the SkinTemplateNavigation::Universal hook

https://gerrit.wikimedia.org/r/605362

Change 605830 merged by jenkins-bot:
[mediawiki/extensions/FileExporter@master] Stop using the SkinTemplateNavigation::SpecialPage hook in favor of the SkinTemplateNavigation::Universal hook

https://gerrit.wikimedia.org/r/605830

Change 605326 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/Vector@master] Favor SkinTemplateNavigation::Universal

https://gerrit.wikimedia.org/r/605326

Change 605326 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Favor SkinTemplateNavigation::Universal

https://gerrit.wikimedia.org/r/605326

Change 625876 had a related patch set uploaded (by Pwirth; owner: Pwirth):
[mediawiki/extensions/AdvancedMeta@REL1_35] Replace usage of deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/625876

Change 625749 had a related patch set uploaded (by Pwirth; owner: Pwirth):
[mediawiki/extensions/AdvancedMeta@master] Replace usage of deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/625749

Change 625878 had a related patch set uploaded (by Pwirth; owner: Pwirth):
[mediawiki/extensions/FlaggedRevs@REL1_35] Replace usage of deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/625878

Change 625750 had a related patch set uploaded (by Pwirth; owner: Pwirth):
[mediawiki/extensions/FlaggedRevs@master] Replace usage of deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/625750

Change 625879 had a related patch set uploaded (by Pwirth; owner: Pwirth):
[mediawiki/extensions/NSFileRepo@REL1_35] Replace usage of deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/625879

Change 625751 had a related patch set uploaded (by Pwirth; owner: Pwirth):
[mediawiki/extensions/NSFileRepo@master] Replace usage of deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/625751

Change 625883 had a related patch set uploaded (by Pwirth; owner: Pwirth):
[mediawiki/extensions/BlueSpiceBookshelf@REL1_35] Replace usage of deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/625883

Change 625884 had a related patch set uploaded (by Pwirth; owner: Pwirth):
[mediawiki/extensions/BlueSpiceExpiry@REL1_35] Replace usage of deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/625884

Change 625901 had a related patch set uploaded (by Pwirth; owner: Pwirth):
[mediawiki/extensions/BlueSpiceInsertCategory@REL1_35] Replace usage of deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/625901

Change 625903 had a related patch set uploaded (by Pwirth; owner: Pwirth):
[mediawiki/extensions/BlueSpicePageAssignments@REL1_35] Replace usage of deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/625903

Change 625904 had a related patch set uploaded (by Pwirth; owner: Pwirth):
[mediawiki/extensions/BlueSpiceReaders@REL1_35] Replace usage of deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/625904

Change 625906 had a related patch set uploaded (by Pwirth; owner: Pwirth):
[mediawiki/extensions/BlueSpiceReminder@REL1_35] Replace usage of deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/625906

Change 626613 had a related patch set uploaded (by Robert Vogel; owner: Pwirth):
[mediawiki/extensions/BlueSpiceReminder@master] Replace usage of deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/626613

Change 626614 had a related patch set uploaded (by Robert Vogel; owner: Pwirth):
[mediawiki/extensions/BlueSpiceBookshelf@master] Replace usage of deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/626614

Change 626615 had a related patch set uploaded (by Robert Vogel; owner: Pwirth):
[mediawiki/extensions/BlueSpiceInsertCategory@master] Replace usage of deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/626615

Change 626616 had a related patch set uploaded (by Robert Vogel; owner: Pwirth):
[mediawiki/extensions/BlueSpiceExpiry@master] Replace usage of deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/626616

Change 626617 had a related patch set uploaded (by Robert Vogel; owner: Pwirth):
[mediawiki/extensions/BlueSpiceReaders@master] Replace usage of deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/626617

Change 625906 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceReminder@REL1_35] Replace usage of deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/625906

Change 625883 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceBookshelf@REL1_35] Replace usage of deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/625883

Change 625901 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceInsertCategory@REL1_35] Replace usage of deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/625901

Change 625884 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceExpiry@REL1_35] Replace usage of deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/625884

Change 625904 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceReaders@REL1_35] Replace usage of deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/625904

Change 626614 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceBookshelf@master] Replace usage of deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/626614

Change 626615 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceInsertCategory@master] Replace usage of deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/626615

Change 626617 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceReaders@master] Replace usage of deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/626617

Change 625751 merged by jenkins-bot:
[mediawiki/extensions/NSFileRepo@master] Replace usage of deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/625751

Change 625879 merged by jenkins-bot:
[mediawiki/extensions/NSFileRepo@REL1_35] Replace usage of deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/625879

Change 625750 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Replace usage of deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/625750

Change 626616 merged by Pwirth:
[mediawiki/extensions/BlueSpiceExpiry@master] Replace usage of deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/626616

Change 626613 merged by Pwirth:
[mediawiki/extensions/BlueSpiceReminder@master] Replace usage of deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/626613

Change 625878 abandoned by Pwirth:
[mediawiki/extensions/FlaggedRevs@REL1_35] Replace usage of deprecated SkinTemplateNavigation hook

Reason:

https://gerrit.wikimedia.org/r/625878

Change 625876 merged by jenkins-bot:
[mediawiki/extensions/AdvancedMeta@REL1_35] Replace usage of deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/625876

Change 625749 merged by jenkins-bot:
[mediawiki/extensions/AdvancedMeta@master] Replace usage of deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/625749

Change 627408 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/TimedMediaHandler@master] Use SkinTemplateNavigation::Universal

https://gerrit.wikimedia.org/r/627408

Change 627408 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Use SkinTemplateNavigation::UniversalHook

https://gerrit.wikimedia.org/r/627408

Change 627952 had a related patch set uploaded (by Robert Vogel; owner: Pwirth):
[mediawiki/extensions/BlueSpicePageAssignments@master] Replace usage of deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/627952

Change 625903 merged by jenkins-bot:
[mediawiki/extensions/BlueSpicePageAssignments@REL1_35] Replace usage of deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/625903

Change 627952 merged by jenkins-bot:
[mediawiki/extensions/BlueSpicePageAssignments@master] Replace usage of deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/627952

Change 630903 had a related patch set uploaded (by Artrix; owner: Artrix):
[mediawiki/extensions/Newsletter@master] Replace usage of deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/630903

Change 630903 merged by jenkins-bot:
[mediawiki/extensions/Newsletter@master] Replace usage of deprecated SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/630903