[1.36] Hard deprecate BaseTemplate::getToolbox method
Closed, ResolvedPublic
Actions

Description

The BaseTemplate::getToolbox method was soft deprecated in 1.35.
It should be hard deprecated in 1.36

Acceptance criteria

When used a warning is thrown when $wgDeprecationWarnings = true

Details

	Subject	Repo	Branch	Lines +/-
	Add release note for BaseTemplate::getToolbox	mediawiki/core	master	+3 -0
	Hard deprecate BaseTemplate::getToolbox()	mediawiki/core	master	+3 -1

Customize query in gerrit

Related Objects

Mentioned In: T266733: [cleanup] Replace deprecated getToolbox() with data['sidebar']['TOOLBOX'] (tracking)

Event Timeline

Jdlrobson created this task.Jun 12 2020, 9:44 PM

Restricted Application added subscribers: Liuxinyu970226, Aklapper. · View Herald TranscriptJun 12 2020, 9:44 PM

Ammarpad claimed this task.Jun 13 2020, 5:32 AM

@Jdlrobson title says 1.36, description says 1.35 - in what version should it be deprecated?

Ammarpad updated the task description. (Show Details)Jun 13 2020, 7:03 AM

Jdlrobson renamed this task from [1.36] Hard deprecate BaseTemplate::getToolbox to [1.36] Remove BaseTemplate::getToolbox.Jun 13 2020, 3:36 PM

Jdlrobson renamed this task from [1.36] Remove BaseTemplate::getToolbox to [1.36] Hard deprecate BaseTemplate::getToolbox.

Jdlrobson renamed this task from [1.36] Hard deprecate BaseTemplate::getToolbox to [1.36] Hard deprecate BaseTemplate::getToolbox method.

Jdlrobson updated the task description. (Show Details)

Jdlrobson moved this task from Phase 3 - standardise template data to Phase 2 - Deprecate and remove Skin methods for readability on the MediaWiki-Core-Skin-Architecture board.Jul 8 2020, 12:07 AM

Jdlrobson triaged this task as High priority.Sep 4 2020, 9:25 PM

Change 627245 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Hard deprecate BaseTemplate::getToolbox()

https://gerrit.wikimedia.org/r/627245

gerritbot added a project: Patch-For-Review.Sep 14 2020, 10:13 AM

Change 627245 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate BaseTemplate::getToolbox()

https://gerrit.wikimedia.org/r/627245

Shoot. We need to update RELEASE-NOTES-1.36 to mention the hard deprecation. Sorry for missing that in code review.

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.9; 2020-09-15).Sep 14 2020, 9:01 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 14 2020, 9:10 PM

Change 627402 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Add release note for BaseTemplate::getToolbox

https://gerrit.wikimedia.org/r/627402

gerritbot added a project: Patch-For-Review.Sep 15 2020, 3:30 AM

In T255321#6460424, @Jdlrobson wrote:

Shoot. We need to update RELEASE-NOTES-1.36 to mention the hard deprecation. Sorry for missing that in code review.

Actually I intentionally omitted it because I noticed it's not being repeated in such cases. I guess that's part of the rationale behind using the version number were the deprecation first occur. But in this case it might worth it, because we did use the 'soft' qualifier in the note. Some cases just say 'deprecated' and so the statement remains true as is even after the subsequent hard deprecation.

Change 627402 merged by jenkins-bot:
[mediawiki/core@master] Add release note for BaseTemplate::getToolbox

https://gerrit.wikimedia.org/r/627402