Page MenuHomePhabricator
Create Task
Maniphest T255323

Process Dialog Navigation wrong focus order
Closed, DeclinedPublicBUG REPORT
Actions

Description

Steps to Reproduce:

  • Launch a wiki page.
  • Navigate till "Edit " and hit enter
  • Navigate till "Insert" and navigate till "More" dropdown, hit enter.
  • Navigate till "Reference List" control, hit enter and hit on edit control.
  • Enter some text in "Use this Group" edit box and "Apply Changes" control gets activated.

Actual Results:

  • Verify Keyboard focus is not logical after "Apply Changes" control.

Expected Results:

  • Keyboard focus should go left to right, top to bottom

Details

SubjectRepoBranchLines +/-
Fixes Process Dialog Navigation Focus Orderoojs/uimaster+1 -1
Customize query in gerrit

Event Timeline

Bkudiess-msft created this task.Jun 12 2020, 9:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 12 2020, 9:59 PM
gerritbot added a comment.Jun 16 2020, 5:08 PM

Change 605969 had a related patch set uploaded (by Bkudiess-msft; owner: Bkudiess-msft):
[oojs/ui@master] Fixes Process Dialog Navigation Focus Order

https://gerrit.wikimedia.org/r/605969

gerritbot added a project: Patch-For-Review.Jun 16 2020, 5:08 PM
matmarex subscribed.Jul 6 2020, 4:54 PM

I'm not sure if this should be changed. I think actions like "Apply changes", "Done", "OK" etc. should be the first in the tab order, even if we have a weird design that puts them in the top-right visually.

Aklapper added a comment.Sep 17 2023, 2:52 PM
In T255323#6282504, @matmarex wrote:

I'm not sure if this should be changed. I think actions like "Apply changes", "Done", "OK" etc. should be the first in the tab order, even if we have a weird design that puts them in the top-right visually.

Does that mean this task and its patch should get declined?

matmarex closed this task as Declined.Sep 17 2023, 10:03 PM

I guess, unless someone disagrees with me.

Good news though, it looks like Wikimedia's next design for dialogs (https://doc.wikimedia.org/codex/latest/components/demos/dialog.html) features buttons in a more traditional arrangement and order.

gerritbot added a comment.Sep 18 2023, 8:20 AM

Change 605969 abandoned by Aklapper:

[oojs/ui@master] Fixes Process Dialog Navigation Focus Order

Reason:

Abandoning per T255323

https://gerrit.wikimedia.org/r/605969

Maintenance_bot removed a project: Patch-For-Review.Sep 18 2023, 8:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL