Page MenuHomePhabricator

installing pytest fails due to pytest-cov requirement
Closed, ResolvedPublic

Description

The new pytest-cov 2.10.0 requires pytest>=4.6 but pytest 4.3.1 is used for Python < 3.5 which is strange because dev-requirements.txt says pytest>=3.6.0,<5.0.0 ; python_version < '3.5'

See https://api.travis-ci.org/v3/job/700032657/log.txt for example

Event Timeline

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald Transcript
Xqt triaged this task as High priority.Jun 13 2020, 3:42 PM
Reedy renamed this task from intalling pytest fails due to pytest-cov requirement to installing pytest fails due to pytest-cov requirement.Jun 14 2020, 12:36 AM

Change 605363 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [dev] Force pytest >= 4.6.0 which is required by pytest-cov 2.10

https://gerrit.wikimedia.org/r/605363

Change 606709 had a related patch set uploaded (by Dvorapa; owner: Dvorapa):
[pywikibot/core@master] [bugfix] Fix pytest, pytest-cov and pytest-timeout requirements

https://gerrit.wikimedia.org/r/606709

Change 605363 abandoned by Xqt:
[dev] Force pytest >= 4.6.0 which is required by pytest-cov 2.10

Reason:
inf favour of https://gerrit.wikimedia.org/r/#/c/pywikibot/core/ /606709/

https://gerrit.wikimedia.org/r/605363

Xqt reassigned this task from Xqt to Dvorapa.

Change 606709 merged by jenkins-bot:
[pywikibot/core@master] [bugfix] Fix pytest, pytest-cov and pytest-timeout requirements

https://gerrit.wikimedia.org/r/606709

CHANGELOG of pytest-cov says they dropped support for py < 3.5, but they mean py3 < 3.5. Arghhhhhhh. Fixed in quick patch, should be ok now

And now 4.1.0 is conflicting. But pytest should not be installed at all.

Dvorapa moved this task from Backlog to CI test failures on the Pywikibot-tests board.

Change 606722 had a related patch set uploaded (by Dvorapa; owner: Dvorapa):
[pywikibot/core@master] [bugfix] Make Travis update pytest

https://gerrit.wikimedia.org/r/606722

Change 606722 merged by jenkins-bot:
[pywikibot/core@master] [bugfix] Make Travis update pytest

https://gerrit.wikimedia.org/r/606722

Last patch works finally. Travis is now forced to uninstall and then reinstall pytest, which resolves all version conflicts.