Terms acceptance call doesn't go through if we are offline, user still uses the app when he shouldn't be allowed
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	• Jpita
	Jun 15 2020, 8:35 AM

Description

Issue

When we accept the terms (on first app boot after install) a call is sent to the logs. When offline, a user can still use some basic functionality on the app.

Request

Users should not be able to accept the terms when offline as this will prevent them from the options to read through the privacy policy and terms of service which are external links that open in the browser.

Expected Behaviour

Show offline panel on the consent screen

Related Objects

Mentioned In: T253561: Update KaiOS app consent flow

Event Timeline

• Jpita created this task.Jun 15 2020, 8:35 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 15 2020, 8:35 AM

• Jpita mentioned this in T253561: Update KaiOS app consent flow.Jun 15 2020, 8:36 AM

• Jpita triaged this task as Unbreak Now! priority.Jun 15 2020, 8:45 AM

• Jpita changed the subtype of this task from "Task" to "Bug Report".

• Jpita edited projects, added Inuka-Team (Kanban); removed Inuka-Team.

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptJun 15 2020, 8:45 AM

RhinosF1 subscribed.Jun 15 2020, 9:33 AM

We could record the consent as "given but not sent" and try to send it again on subsequent opening of the app.

SBisson lowered the priority of this task from Unbreak Now! to High.Jun 15 2020, 1:25 PM

hueitan claimed this task.Jun 15 2020, 1:59 PM

• AMuigai removed hueitan as the assignee of this task.Jun 15 2020, 2:01 PM

• AMuigai updated the task description. (Show Details)

• AMuigai moved this task from Backlog to Ready for Dev on the Inuka-Team (Kanban) board.

• AMuigai added a subscriber: hueitan.

hueitan claimed this task.Jun 15 2020, 2:04 PM

hueitan moved this task from Ready for Dev to Dev on the Inuka-Team (Kanban) board.

What softkeys, if any, should be available when the consent screen shows the offline panel?

In the current version of this PR https://github.com/wikimedia/wikipedia-kaios/pull/249, CSK hidden and the rest remain, let me know if this needs to be changed.

hueitan moved this task from Dev to Code Review on the Inuka-Team (Kanban) board.Jun 15 2020, 3:02 PM

hueitan moved this task from Code Review to QA on the Inuka-Team (Kanban) board.Jun 15 2020, 7:57 PM

• Jpita moved this task from QA to Design sign off on the Inuka-Team (Kanban) board.Jun 16 2020, 3:09 AM

In T255397#6224179, @SBisson wrote:

What softkeys, if any, should be available when the consent screen shows the offline panel?

I'd advise to show it without any softkey.

Move to dev as it requires more update on the softkey.

hueitan moved this task from Dev to Code Review on the Inuka-Team (Kanban) board.Jun 16 2020, 10:54 AM

SBisson moved this task from Code Review to QA on the Inuka-Team (Kanban) board.Jun 16 2020, 7:39 PM

SBisson moved this task from QA to Code Review on the Inuka-Team (Kanban) board.Jun 16 2020, 7:43 PM

SBisson moved this task from Code Review to QA on the Inuka-Team (Kanban) board.

SBisson moved this task from Backlog to Jio2 on the KaiOS-Wikipedia-app board.Jun 18 2020, 3:46 PM

SBisson edited projects, added KaiOS-Wikipedia-app (Jio2); removed KaiOS-Wikipedia-app.

The current behaviour is:

when there is no internet, the "no connection" image appears and no options are available for the user to proceed to the app

Is this the expected behaviour @AMuigai ?

Expected, user can only use backspace key to exit the app.

• Jpita moved this task from QA WAITING FOR FEEDBACK to Design sign off on the Inuka-Team (Kanban) board.Jun 22 2020, 9:57 AM

Yes, that is the expected behaviour. Until a user can agree to the TOS and
Privacy Policy, no options within the app can be used.

Working as expected, moving it for product signoff.

SGautam_WMF moved this task from Design sign off to Product sign off on the Inuka-Team (Kanban) board.Jun 23 2020, 4:27 AM

• AMuigai closed this task as Resolved.Jun 29 2020, 11:26 AM

Terms acceptance call doesn't go through if we are offline, user still uses the app when he shouldn't be allowedClosed, ResolvedPublicBUG REPORTActions