| Addshore | |
| Jun 15 2020, 10:43 AM |
| F31920892: image.png | |
| Jul 8 2020, 11:45 AM |
Alter the formatter-factory-callback for WikibaseRepo.datatypes.php PT:wikibase-property to use the new linking formatter that we just created in T255418
We should keep the PY:wikibase-item formatter the same (not linking)
This will likely require splitting the newItemPropertyIdHtmlLinkFormatter method into 2 methods, one for Items and one for Properties, each injecting the right NonExistingEntityIdHtmlFormatter for the situation (right now that is not injected, but made in the constructor)
| Project | Branch | Lines +/- | Subject | |
|---|---|---|---|---|
| mediawiki/extensions/Wikibase | master | +154 -34 | FP: View details of a deleted property used in a statement |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Addshore | T251743 View details of a deleted property used in a statement | |||
| Resolved | Rosalie_WMDE | T255417 Make PT:wikibase-property use the new linking NonExistingEntityIdHtmlFormatter |
Change 609456 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)):
[mediawiki/extensions/Wikibase@master] View details of a deleted property used in a statement
Testing this now in patch 609456,8 I was expecting the whole link including the Deleted property notice to be red. Do we have any design input here? @Samantha_Alipio_WMDE @Rosalie_WMDE
Testing this now in patch 609456,8 I was expecting the whole link including the Deleted property notice to be red. Do we have any design input here? @Samantha_Alipio_WMDE @Rosalie_WMDE
Hey! It's unclear to me if the words "(Deleted Property)" are part of the hyperlink in your screenshot. Only P3 should be hyperlinked, so that is the only piece that is to be formatted in red (as it is a link ot a nonexistent page). See T251743.
Change 609456 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: View details of a deleted property used in a statement