Page MenuHomePhabricator

Make PT:wikibase-property use the new linking NonExistingEntityIdHtmlFormatter
Closed, ResolvedPublic

Description

Alter the formatter-factory-callback for WikibaseRepo.datatypes.php PT:wikibase-property to use the new linking formatter that we just created in T255418

We should keep the PY:wikibase-item formatter the same (not linking)
This will likely require splitting the newItemPropertyIdHtmlLinkFormatter method into 2 methods, one for Items and one for Properties, each injecting the right NonExistingEntityIdHtmlFormatter for the situation (right now that is not injected, but made in the constructor)

Event Timeline

Addshore updated the task description. (Show Details)

Change 609456 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)):
[mediawiki/extensions/Wikibase@master] View details of a deleted property used in a statement

https://gerrit.wikimedia.org/r/609456

Addshore triaged this task as Medium priority.Jul 8 2020, 10:35 AM
toan added a subscriber: toan.Jul 8 2020, 11:45 AM

Testing this now in patch 609456,8 I was expecting the whole link including the Deleted property notice to be red. Do we have any design input here? @Samantha_Alipio_WMDE @Rosalie_WMDE

Testing this now in patch 609456,8 I was expecting the whole link including the Deleted property notice to be red. Do we have any design input here? @Samantha_Alipio_WMDE @Rosalie_WMDE

Hey! It's unclear to me if the words "(Deleted Property)" are part of the hyperlink in your screenshot. Only P3 should be hyperlinked, so that is the only piece that is to be formatted in red (as it is a link ot a nonexistent page). See T251743.

Change 609456 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: View details of a deleted property used in a statement

https://gerrit.wikimedia.org/r/609456

Addshore closed this task as Resolved.Jul 22 2020, 8:09 AM

Resolved as it's in the Done column at the end of sprint 3 (start of sprint 4)