Page MenuHomePhabricator

Take down the aggressiveness of the discard edit message a notch
Open, Needs TriagePublic

Description

Problem:

The modal + red button is excessive for a reply interface

Screenshot:

Screen Shot 2020-06-15 at 9.25.15 AM.png (394×854 px, 90 KB)

Possible Solutions:

  • Make dialog box less aggressive by downgrading the button from ButtonWidget (destructive)
  • Removing this message completely and storing/cache
  • Changing language in the dialog box (note: can you actually save a reply?)

Event Timeline

Make dialog box less aggressive by downgrading the button from ButtonWidget (destructive)

We kind of did this as a side-effect of T249880, the dialog looks like this now:

image.png (490×1 px, 62 KB)

Does that make it alright or do you have something different in mind?

(note: can you actually save a reply?)

I think that's just a residue of the save -> publish change.

The modal + red button is excessive for a reply interface ... Make dialog box less aggressive ...

I'm not sure I agree with this. The button they pressed will discard everything you have written without an option to undo, so it is accordingly highlighted to warn the user.

Removing this message completely and storing/cache

We auto-save the message for recovery. This is only shown if the user presses "cancel" or tries to navigate away, which would result in their comment being lost.

Changing language in the dialog box (note: can you actually save a reply?)

This is T241403