Take down the aggressiveness of the discard edit message a notch
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	• iamjessklein
	Jun 15 2020, 1:44 PM

Description

Problem:

The modal + red button is excessive for a reply interface

Screenshot:

Possible Solutions:

Make dialog box less aggressive by downgrading the button from ButtonWidget (destructive)
Removing this message completely and storing/cache
Changing language in the dialog box (note: can you actually save a reply?)

Related Objects

Mentioned In: T249880: VisualEditor: "Discard edits" should not be focused by default in the AbandonEditDialog
T234403: Create a VE-based text input for replying
Mentioned Here: T241403: Make talk page language discussion-specific
T249880: VisualEditor: "Discard edits" should not be focused by default in the AbandonEditDialog

Event Timeline

• iamjessklein created this task.Jun 15 2020, 1:44 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 15 2020, 1:44 PM

• iamjessklein mentioned this in T234403: Create a VE-based text input for replying.Jun 15 2020, 1:48 PM

scblr subscribed.Jun 15 2020, 1:49 PM

• ppelberg subscribed.Jun 16 2020, 12:06 AM

Make dialog box less aggressive by downgrading the button from ButtonWidget (destructive)

We kind of did this as a side-effect of T249880, the dialog looks like this now:

Does that make it alright or do you have something different in mind?

matmarex mentioned this in T249880: VisualEditor: "Discard edits" should not be focused by default in the AbandonEditDialog.Jun 16 2020, 12:46 PM

(note: can you actually save a reply?)

I think that's just a residue of the save -> publish change.

• ppelberg moved this task from Needs Prioritization to Required after release on the OWC2020 (OWC2020 Replying 2.0) board.Jun 18 2020, 5:04 AM

• ppelberg added a parent task: T256082: Ensure the Reply tool has an obvious purpose.Jun 22 2020, 11:50 PM

• ppelberg moved this task from 📚 Backlog to 📢 To Do on the Editing Design board.Jun 23 2020, 12:04 AM

Esanders added a project: DiscussionTools.Jun 25 2020, 12:50 PM

The modal + red button is excessive for a reply interface ... Make dialog box less aggressive ...

I'm not sure I agree with this. The button they pressed will discard everything you have written without an option to undo, so it is accordingly highlighted to warn the user.

Removing this message completely and storing/cache

We auto-save the message for recovery. This is only shown if the user presses "cancel" or tries to navigate away, which would result in their comment being lost.

Changing language in the dialog box (note: can you actually save a reply?)

This is T241403

scblr unsubscribed.Jun 25 2020, 12:59 PM

• ppelberg removed a parent task: T256082: Ensure the Reply tool has an obvious purpose.Jul 3 2020, 5:28 PM

• ppelberg moved this task from Required after release to Freezer on the OWC2020 (OWC2020 Replying 2.0) board.

• ppelberg moved this task from 📢 To Do to 📚 Backlog on the Editing Design board.

MBinder_WMF added a project: Editing-team (Design Backlog).Feb 10 2021, 1:18 AM

Closing per T255443#6227830.

	F31866542: Screen Shot 2020-06-15 at 9.25.15 AM.png
	Jun 15 2020, 1:44 PM

	F31867989: image.png
	Jun 16 2020, 12:38 PM

Take down the aggressiveness of the discard edit message a notchClosed, ResolvedPublicActions