Clean up toolbar tab alignment
Closed, InvalidPublic
Actions

Assigned To

None

Authored By

	• iamjessklein
	Jun 15 2020, 2:18 PM

Description

Problem

The placement of tabs, as well as the alignment of the prompting text feels messy.

Screenshot

User talk:Alice2 - devwiki 2020-06-15 10-00-02.png (476×480 px, 45 KB)

Possible Solutions

Consider upstream changes to OOUI
Left align tabs
Align text with the first tab
Change to tabbed layout
Using the line of the box as the guiding line to match:

Screen Shot 2020-06-15 at 10.15.17 AM.png (104×366 px, 10 KB)

other?

Related Tickets

T252445

Related Objects
Search...

Status	Assigned	Task
Open	None	T233443 [Epic] Reply Tool
Open	None	T252445 Consider changing the presentation of the visual mode's editing toolbar
Invalid	None	T255445 Clean up toolbar tab alignment

Event Timeline

• iamjessklein created this task.Jun 15 2020, 2:18 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 15 2020, 2:18 PM

• iamjessklein mentioned this in T234403: Create a VE-based text input for replying.Jun 15 2020, 2:21 PM

ppelberg added a parent task: T252445: Consider changing the presentation of the visual mode's editing toolbar.Jun 15 2020, 9:45 PM

ppelberg moved this task from Needs Prioritization to Required after release on the OWC2020 (OWC2020 Replying 2.0) board.Jun 22 2020, 11:40 PM

ppelberg added a parent task: T256080: Ensure the Reply tool makes a good first impression.Jun 22 2020, 11:46 PM

ppelberg moved this task from 📚 Backlog to 📢 To Do on the Editing Design board.Jun 23 2020, 12:03 AM

ppelberg subscribed.

ppelberg moved this task from 📢 To Do to 📚 Backlog on the Editing Design board.Jun 23 2020, 3:49 PM

Esanders added a project: DiscussionTools.Jun 25 2020, 12:50 PM

ppelberg moved this task from Required after release to Required for Release on the OWC2020 (OWC2020 Replying 2.0) board.Jul 3 2020, 4:49 PM

@iamjessklein do you have conviction about which of the "Possible Solutions" listed in the task description we ought to implement here?

If yes, please comment as much so we can implement it.

If not, I think we should de-prioritize this for.

ppelberg moved this task from 📚 Backlog to 📢 To Do on the Editing Design board.Jul 10 2020, 11:48 PM

This should be rethought for sure after T257280—now the mode tabs are most probably not a problem, but the visual mode toolbar may have become one.

In T255445#6298086, @Tacsipacsi wrote:

...but the visual mode toolbar may have become one.

@Tacsipacsi can you share a bit more here...what problems are you noticing about the visual mode's toolbar?

The same as previously with the mode switch tabs: the toolbar’s B is a bit more indented compared to the text input. But I’m not sure if it’s really an issue, given the one is an icon and the other is running text; I have no opinion on whether the current appearance is better or the text input should be indented more.

Reply tool visual toolbar vs text input.png (100×254 px, 4 KB)

ppelberg moved this task from 📢 To Do to 📐 Doing on the Editing Design board.Jul 14 2020, 12:54 AM

In T255445#6302549, @Tacsipacsi wrote:

The same as previously with the mode switch tabs: the toolbar’s B is a bit more indented compared to the text input. But I’m not sure if it’s really an issue, given the one is an icon and the other is running text; I have no opinion on whether the current appearance is better or the text input should be indented more.

Ah, understood. And thank you for putting together this visual, @Tacsipacsi; it made what you were referring instantly clear to me.

...below are what I see to be the next steps as it relates to this ticket.

Next steps

1. @iamjessklein to test the new tool location: T257281
2. @ppelberg to determine whether the change in tool location should be deployed: T257280
3. @iamjessklein to determine what – if any – work should be done on this ticket (T255445)