Page MenuHomePhabricator
Create Task
Maniphest T255479

Replace count metric with timing metric for WAN cache gets
Closed, ResolvedPublic
Actions

Description

This can be used to help gauge any effects of T244340

Note that we already having timing metrics for the set path

Details

SubjectRepoBranchLines +/-
objectcache: replace count metric with timing metric for WAN cache getsmediawiki/coremaster+27 -8
Customize query in gerrit

Related Objects

Event Timeline

aaron created this task.Jun 15 2020, 8:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 15 2020, 8:16 PM
• Gilles moved this task from Inbox, needs triage to Doing (old) on the Performance-Team board.Jun 22 2020, 8:02 PM
Krinkle moved this task from General to libs/objectcache on the MediaWiki-libs-BagOStuff board.Jun 22 2020, 8:02 PM
Krinkle triaged this task as Low priority.Jul 20 2020, 8:26 PM
gerritbot added a comment.Jul 29 2020, 11:45 PM

Change 617291 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@master] objectcache: replace count metric with timing metric for WAN cache gets

https://gerrit.wikimedia.org/r/617291

gerritbot added a project: Patch-For-Review.Jul 29 2020, 11:45 PM
gerritbot added a comment.Sep 28 2020, 7:49 PM

Change 617291 merged by jenkins-bot:
[mediawiki/core@master] objectcache: replace count metric with timing metric for WAN cache gets

https://gerrit.wikimedia.org/r/617291

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.11; 2020-09-29).Sep 28 2020, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 28 2020, 8:11 PM
aaron added a comment.Sep 30 2020, 4:29 AM

The Grafana dashboards will still need updating.

Krinkle subscribed.Oct 26 2020, 6:54 PM

Still todo, on https://grafana.wikimedia.org/d/lqE4lcGWz/wanobjectcache-key-group.

aaron closed this task as Resolved.Oct 26 2020, 7:27 PM

Added cache hit latency panel

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL