Maniphest T255492

Consider making ILoadBalancer::getServerConnection private or internal
Closed, ResolvedPublic
Actions

Description

Follow-up from T236880: Document when to use different ILoadBalancer::get*Connection* methods

It seems there is not currently use of this method outside Rdbms internals. Seems like an easy one to remove from the public API, in favour of getConnection.

In general external callers should not be concerned about the host/ports of individual database servers. If they aware of such servers, they either need to ignore that knowledge, or create their own LBFactory. There is presumably no known use case for how an external caller could know about a specific dbhost, know it is present in LBFactory, and not be in change of having that same LBFactory instance.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	rdbms: mark getServerConnection() as @internal	mediawiki/core	master	+1 -0

Customize query in gerrit

Related Objects

Mentioned In: T236880: Document when to use different ILoadBalancer::get*Connection* methods
Mentioned Here: T236880: Document when to use different ILoadBalancer::get*Connection* methods

Event Timeline

Krinkle created this task.Jun 15 2020, 9:08 PM

Restricted Application added a project: Platform Engineering. · View Herald TranscriptJun 15 2020, 9:08 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Krinkle mentioned this in T236880: Document when to use different ILoadBalancer::get*Connection* methods.Jun 15 2020, 9:24 PM

TK-999 subscribed.Jun 15 2020, 9:47 PM

To accompany other ILoadBalancer work.

Naike added a project: Platform Engineering Roadmap Decision Making.Oct 9 2020, 1:02 PM

Naike moved this task from Untriaged to Icebox on the Platform Engineering Roadmap Decision Making board.Nov 16 2020, 3:24 PM

• CCicalese_WMF removed a project: Platform Engineering.Feb 24 2021, 11:38 PM

Krinkle moved this task from Untriaged to Rdbms library on the MediaWiki-libs-Rdbms board.Oct 16 2021, 1:37 AM

Restricted Application added a project: Performance-Team. · View Herald TranscriptOct 16 2021, 1:37 AM

Change 731794 had a related patch set uploaded (by Aaron Schulz; author: Aaron Schulz):

[mediawiki/core@master] rdbms: mark getServerConnection() as @internal

https://gerrit.wikimedia.org/r/731794

gerritbot added a project: Patch-For-Review.Oct 18 2021, 6:50 PM

Krinkle moved this task from Inbox, needs triage to Backlog: Maintenance, non-prioritized on the Performance-Team board.Oct 23 2021, 2:50 AM

Change 731794 merged by jenkins-bot:

[mediawiki/core@master] rdbms: mark getServerConnection() as @internal

https://gerrit.wikimedia.org/r/731794

Maintenance_bot removed a project: Patch-For-Review.Oct 23 2021, 3:10 AM

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.6; 2021-10-26).Oct 23 2021, 4:00 AM

aaron closed this task as Resolved.Oct 25 2021, 6:12 PM

aaron claimed this task.