Page MenuHomePhabricator

Increase padding around Icon in warning
Closed, ResolvedPublic

Description

Problem:

The padding around the Warning icon in the logged out message is too tight

Screenshot:

Possible Solutions:

  • Increase the padding (.5-1.25em)

Event Timeline

@iamjessklein, the task description leads me to think this ticket is "Ready for development." If this is not the case (read: further discussion is needed), please comment as much.

@iamjessklein, the task description leads me to think this ticket is "Ready for development." If this is not the case (read: further discussion is needed), please comment as much.

Confirmed: this is good to go. Whoever picks this up, please consult @iamjessklein is questions arise.

Change 608630 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/DiscussionTools@master] Increase padding around warning icon

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/ /608630

The above patch maintains the horizontal padding of the original widget (which uses a smaller icon):

Change 608630 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Increase padding around warning icon

https://gerrit.wikimedia.org/r/608630

JTannerWMF added a subscriber: JTannerWMF.

We got the green light from @iamjessklein and @ppelberg