Maniphest T255558

Increase padding around Icon in warning
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• iamjessklein
	Jun 16 2020, 1:10 PM

Tags

Referenced Files

	F31911843: image.png
	Jun 30 2020, 2:19 PM

	F31868015: screen_shot_2020-06-15_at_11.05.27_am.png
	Jun 16 2020, 1:10 PM

Subscribers

• iamjessklein

Description

Problem:

The padding around the Warning icon in the logged out message is too tight

Screenshot:

screen_shot_2020-06-15_at_11.05.27_am.png (620×1 px, 92 KB)

Possible Solutions:

Increase the padding (.5-1.25em)

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Increase padding around warning icon	mediawiki/extensions/DiscussionTools	master	+2 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		ppelberg	T256080 Ensure the Reply tool makes a good first impression
		Resolved		Esanders	T255558 Increase padding around Icon in warning

Event Timeline

• iamjessklein created this task.Jun 16 2020, 1:10 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 16 2020, 1:10 PM

• iamjessklein mentioned this in T234403: Create a VE-based text input for replying.Jun 16 2020, 2:30 PM

ppelberg moved this task from Needs Prioritization to Required after release on the OWC2020 (OWC2020 Replying 2.0) board.Jun 22 2020, 11:30 PM

ppelberg added a parent task: T256080: Ensure the Reply tool makes a good first impression.Jun 22 2020, 11:46 PM

ppelberg moved this task from 📚 Backlog to 📢 To Do on the Editing Design board.Jun 23 2020, 12:03 AM

@iamjessklein, the task description leads me to think this ticket is "Ready for development." If this is not the case (read: further discussion is needed), please comment as much.

ppelberg edited projects, added Editing-team (Q3 2019-2020 Kanban Board); removed Editing Design.Jun 23 2020, 3:47 PM

ppelberg moved this task from Needs Discussion / Investigation to Upcoming on the Editing-team (Q3 2019-2020 Kanban Board) board.

In T255558#6248816, @ppelberg wrote:

@iamjessklein, the task description leads me to think this ticket is "Ready for development." If this is not the case (read: further discussion is needed), please comment as much.

Confirmed: this is good to go. Whoever picks this up, please consult @iamjessklein is questions arise.

Esanders added a project: DiscussionTools.Jun 25 2020, 12:49 PM

ppelberg moved this task from Upcoming to Ready for Development on the Editing-team (Q3 2019-2020 Kanban Board) board.Jun 30 2020, 1:34 AM

Esanders updated the task description. (Show Details)Jun 30 2020, 2:18 PM

Change 608630 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/DiscussionTools@master] Increase padding around warning icon

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/ /608630

gerritbot added a project: Patch-For-Review.Jun 30 2020, 2:19 PM

The above patch maintains the horizontal padding of the original widget (which uses a smaller icon):

image.png (297×949 px, 27 KB)

Esanders moved this task from Ready for Development to Code Review on the Editing-team (Q3 2019-2020 Kanban Board) board.Jun 30 2020, 2:19 PM

Esanders claimed this task.Jul 2 2020, 1:47 PM

@iamjessklein adding this to Editing Design as it needs design review.

ppelberg added a project: Editing Design.Jul 3 2020, 3:56 PM

ppelberg moved this task from Required after release to Required for Release on the OWC2020 (OWC2020 Replying 2.0) board.Jul 3 2020, 4:49 PM

MBinder_WMF edited projects, added Editing-team (Kanban Board); removed Editing-team (Q3 2019-2020 Kanban Board).Jul 9 2020, 4:50 PM

JTannerWMF moved this task from Inbox to Code Review on the Editing-team (Kanban Board) board.Jul 9 2020, 4:50 PM

Change 608630 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Increase padding around warning icon

https://gerrit.wikimedia.org/r/608630

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.1; 2020-07-21).Jul 17 2020, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 17 2020, 4:10 PM

matmarex moved this task from Code Review to Ready for Sign Off on the Editing-team (Kanban Board) board.Jul 17 2020, 4:12 PM

matmarex added a project: Skipped QA.

We got the green light from @iamjessklein and @ppelberg