Maniphest T255574

Watchlist star gone on Vector
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to Reproduce:

Go to any page on a group0 wiki, e.g. https://www.mediawiki.org/wiki/MediaWiki (legacy, new Vector).
Look at the action tabs in the upper right corner.

Actual Results:

Next to Read, View source and View history there’s a tab called Watch.

Expected Results:

The last tab shows a star icon.

Further Details:

This affects only group0 wikis, not group1 or group2, so it arrived with wmf37 (T254174). Not sure if it’s a train blocker.
Both legacy and new Vector are affected.

Details

Subject	Repo	Branch	Lines +/-
Restore Watchlist star	mediawiki/skins/Vector	wmf/1.35.0-wmf.37	+4 -4
Restore Watchlist star	mediawiki/skins/Vector	master	+4 -4
Revert "Replace deprecated classes with modern ones"	mediawiki/skins/Vector	master	+27 -18

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	• LarsWirzenius	T254174 1.35.0-wmf.37 deployment blockers
		Resolved	BUG REPORT	• Demian	T255574 Watchlist star gone on Vector

Event Timeline

Tacsipacsi created this task.Jun 16 2020, 3:31 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 16 2020, 3:31 PM

Krinkle triaged this task as Unbreak Now! priority.Jun 16 2020, 4:04 PM

Krinkle added a subtask: T254174: 1.35.0-wmf.37 deployment blockers.

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptJun 16 2020, 4:04 PM

Krinkle removed a subtask: T254174: 1.35.0-wmf.37 deployment blockers.Jun 16 2020, 4:04 PM

Krinkle added a parent task: T254174: 1.35.0-wmf.37 deployment blockers.

Probably caused by the Desktop Improvements (Vector 2022) work?

Possibly caused by ca71f762faadaa91be27d8c4c45babc111e59f49, but that landed in wmf.34, so it seems unlikely.

• LarsWirzenius subscribed.Jun 16 2020, 4:30 PM

• LarsWirzenius added a project: Web-Team-Backlog.Jun 16 2020, 4:32 PM

brennen subscribed.Jun 16 2020, 4:42 PM

Change 605966 had a related patch set uploaded (by Aron Manning; owner: Aron Manning):
[mediawiki/skins/Vector@master] Restore Watchlist star

https://gerrit.wikimedia.org/r/605966

gerritbot added a project: Patch-For-Review.Jun 16 2020, 4:56 PM

Caused by .vector-tabs selector in patch 604858 instead of .vector-menu-tabs (code)

Ladsgroup subscribed.Jun 16 2020, 5:06 PM

Change 605970 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/Vector@master] Revert "Replace deprecated classes with modern ones"

https://gerrit.wikimedia.org/r/605970

Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-2019-20-Q4); removed Web-Team-Backlog.Jun 16 2020, 5:15 PM

Change 605970 abandoned by Jdlrobson:
Revert "Replace deprecated classes with modern ones"

Reason:
Doesn't revert cleanly.

https://gerrit.wikimedia.org/r/605970

Jdlrobson mentioned this in T255591: [Dev] Watchstar CSS should not rely on menu classes.Jun 16 2020, 5:36 PM

Change 605975 had a related patch set uploaded (by Jdlrobson; owner: Aron Manning):
[mediawiki/skins/Vector@wmf/1.35.0-wmf.37] Restore Watchlist star

https://gerrit.wikimedia.org/r/605975

Jdlrobson assigned this task to Edtadros.Jun 16 2020, 5:47 PM

Jdlrobson moved this task from Needs Analysis to Needs QA on the Web-Team-Backlog (Kanbanana-2019-20-Q4) board.

Change 605966 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Restore Watchlist star

https://gerrit.wikimedia.org/r/605966

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.38; 2020-06-23).Jun 16 2020, 6:00 PM

Mentioned in SAL (#wikimedia-operations) [2020-06-16T19:01:02Z] <brennen> holding 1.35.0-wmf.27 deploy to group1 for a few minutes while merging & testing fix for T255574

Mentioned in SAL (#wikimedia-operations) [2020-06-16T19:03:27Z] <brennen> CORRECTION: holding _1.35.0-wmf.37_ deploy to group1 for a few minutes while merging & testing fix for T255574