related API
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	cooltey
	Jun 16 2020, 3:48 PM

Description

Steps to Reproduce:

Search /dev/random in Wikipedia Android app
Go to the bottom of the page to see if the related pages being loaded.

Actual Results:

Not showing related pages

Expected Results:

Showing related pages

Note

By checking the log, I have found the title did not encoded correctly, which will cause a "title not found" error.
https://en.wikipedia.org/api/rest_v1/page/related//dev/random
and it should be:
https://en.wikipedia.org/api/rest_v1/page/related/%2Fdev%2Frandom

Details

	Subject	Repo	Branch	Lines +/-
	Footer.add: remove title param	mediawiki/services/mobileapps	master	+8 -9
	Hygiene: document that title must be encoded	mediawiki/services/mobileapps	master	+2 -1

Customize query in gerrit

Event Timeline

cooltey created this task.Jun 16 2020, 3:48 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 16 2020, 3:48 PM

LGoto triaged this task as Medium priority.Jun 24 2020, 3:50 PM

LGoto moved this task from Needs triage to Upcoming on the Product-Infrastructure-Team-Backlog-Deprecated board.

• bearND claimed this task.Jun 25 2020, 9:00 PM

• bearND moved this task from Upcoming to Kanban on the Product-Infrastructure-Team-Backlog-Deprecated board.

• bearND edited projects, added Product-Infrastructure-Team-Backlog-Deprecated (Kanban); removed Product-Infrastructure-Team-Backlog-Deprecated.

• bearND moved this task from To Do to Doing on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.

This is because when the Android app calls pcs.c1.Footer.add() it doesn't percent-encode the title. I've created a PR[1] to show what should happen.

I wonder if it would be easier to just remove these parameters (title and baseURL) and just have the JS code get them from document.location.pathname to avoid this confusion.
You can see this in action when adding the footer=true query param: https://en.wikipedia.org/api/rest_v1/page/mobile-html/%2Fdev%2Frandom?footer=true.

[1] https://github.com/wikimedia/apps-android-wikipedia/pull/1344

Change 607893 had a related patch set uploaded (by BearND; owner: BearND):
[mediawiki/services/mobileapps@master] Hygiene: document that title must be encoded

https://gerrit.wikimedia.org/r/607893

gerritbot added a project: Patch-For-Review.Jun 25 2020, 10:21 PM

• bearND moved this task from Doing to Code Review on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Jun 25 2020, 10:29 PM

• Charlotte moved this task from Needs Triage to Tracking on the Wikipedia-Android-App-Backlog board.Jun 26 2020, 3:31 PM

Change 607893 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Hygiene: document that title must be encoded

https://gerrit.wikimedia.org/r/c/mediawiki/services/mobileapps/ /607893

• bearND moved this task from Code Review to To Deploy on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Jul 7 2020, 3:35 PM

~~This should be fixed client-side by the Android app.~~

Update: Just noticed the comments on my Android app patch that this is more complicated on the client side. How about we change the PCS JS to ignore the title that is set by the client and figure it out from window.location?

• bearND moved this task from To Deploy to Doing on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Jul 7 2020, 4:00 PM

Change 610114 had a related patch set uploaded (by BearND; owner: BearND):
[mediawiki/services/mobileapps@master] Footer.add: remove title param

https://gerrit.wikimedia.org/r/610114

@cooltey @Dbrant @JoeWalsh What do you think about my proposal (see patch above) to remove the title parameter from Footer.add()? Is there a real need for the client to specify the title at all? Just checking to make sure this approach makes sense.