Page MenuHomePhabricator

MoreMenu gadget UI bug in Vector
Closed, ResolvedPublic

Description

On Group0 wikis (I assume because the Deployment Train arrived today), I see the MoreMenu gadget displaying incorrectly. I would guess this is related to recent skin work.

Gadget: https://meta.wikimedia.org/wiki/MoreMenu

Event Timeline

Quiddity created this task.Jun 16 2020, 6:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 16 2020, 6:21 PM
Aklapper renamed this task from MoreMenu UI bug in Vector to MoreMenu gadget UI bug in Vector.EditedJun 16 2020, 7:42 PM

I think this is because of T254797. I didn't realize the deadline was so soon... working on a fix now!

Looks like this should be reported at https://github.com/MusikAnimal/MoreMenu/issues instead, according to https://meta.wikimedia.org/wiki/MoreMenu ?

Probably yes, since there's no suitable project here on Phabricator.

Thanks for taking care of it, @MusikAnimal!

MusikAnimal closed this task as Resolved.Jun 16 2020, 9:34 PM

I think everything is fixed now. I am really glad I spent November-December 2019 migrating all wikis to use the global gadget! JavaScript changes only had to happen in one place :) In this case the peer gadget CSS had to be updated too (which can't be "global" since it has to be behind ResourceLoader), so I did have to manually update those on all the applicable wikis, but at least I had a list to go by.