Page MenuHomePhabricator

Special:MovePage: Invalid atomic section ended (got MovePage::moveUnsafe but expected Flow\BoardMover)
Closed, DuplicatePublic

Description

Error

MediaWiki version: 1.35.0-wmf.37

message
Invalid atomic section ended (got MovePage::moveUnsafe but expected Flow\BoardMover)

Impact

3 of these for office, so I'm not sure if there's a public-facing impact.

Details

Request ID
31b47541-9f90-48e9-8269-9bee9621e4c5
Request URL
https://office.wikimedia.org/w/index.php?title=Special:MovePage&action=submit
Stack Trace
exception.trace
#0 /srv/mediawiki/php-1.35.0-wmf.37/includes/MovePage.php(703): Wikimedia\Rdbms\Database->endAtomic(string)
#1 /srv/mediawiki/php-1.35.0-wmf.37/includes/MovePage.php(412): MovePage->moveUnsafe(User, string, boolean, array)
#2 /srv/mediawiki/php-1.35.0-wmf.37/includes/specials/SpecialMovepage.php(773): MovePage->moveIfAllowed(User, string, boolean)
#3 /srv/mediawiki/php-1.35.0-wmf.37/includes/specials/SpecialMovepage.php(137): MovePageForm->doSubmit()
#4 /srv/mediawiki/php-1.35.0-wmf.37/includes/specialpage/SpecialPage.php(580): MovePageForm->execute(NULL)
#5 /srv/mediawiki/php-1.35.0-wmf.37/includes/specialpage/SpecialPageFactory.php(634): SpecialPage->run(NULL)
#6 /srv/mediawiki/php-1.35.0-wmf.37/includes/MediaWiki.php(307): MediaWiki\SpecialPage\SpecialPageFactory->executePath(Title, RequestContext)
#7 /srv/mediawiki/php-1.35.0-wmf.37/includes/MediaWiki.php(986): MediaWiki->performRequest()
#8 /srv/mediawiki/php-1.35.0-wmf.37/includes/MediaWiki.php(543): MediaWiki->main()
#9 /srv/mediawiki/php-1.35.0-wmf.37/index.php(47): MediaWiki->run()
#10 /srv/mediawiki/w/index.php(3): require(string)
#11 {main}

Event Timeline

brennen created this task.Jun 16 2020, 7:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 16 2020, 7:43 PM
DannyS712 added subscribers: daniel, Pchelolo, DannyS712.

Probably caused by 5f21ebd4c52f5bc9e49c96e35dedb6605dcacee2 as part of T250023: Replace TitleMoveComplet(e|ing) hooks
The TitleMoveCompleting hook is part of the page move`s atomic section, the TitleMoveComplete and the new PageMoveComplete hooks are part of the deferred atomic update.
I originally proposed that two hooks be added to replace these, but @daniel suggested that only one may be needed.

Note: if the flow commit is reverted, 8f7f133ccfaaaa45b7c00835d3d64884bde0c5c3 needs to be reverted first