Page MenuHomePhabricator
Create Task
Maniphest T255617

TypeError: rects is null (from VE FindAndReplaceDialog)
Closed, DuplicatePublic
Actions

Description

Caught by our client side error reporting on French Wikipedia.

at ve.ui.FindAndReplaceDialog.prototype.renderRangeOfFragments URL1:823:848
at ve.ui.FindAndReplaceDialog.prototype.renderFragments URL1:823:26
at run URL2:636:645

URL1: https://fr.wikipedia.org/w/load.php?lang=fr&modules=ext.visualEditor.articleTarget%2Cbase%2Ccore%2CdesktopArticleTarget%2CdesktopTarget%2Cdiffing%2Cicons%2Clanguage%2Cmediawiki%2Cmwalienextension%2Cmwcore%2Cmwextensions%2Cmwformatting%2Cmwgallery%2Cmwimage%2Cmwlanguage%2Cmwlink%2Cmwmeta%2Cmwsave%2Cmwsignature%2Cmwtransclusion%2Cmwwikitext%2Csanitize%2Cswitching%2Cwelcome%7Cext.visualEditor.core.desktop%2Cutils%7Cext.visualEditor.mwextensions.desktop%7Cext.visualEditor.mwimage.core&skin=vector&version=jnnun
URL2: https://fr.wikipedia.org/w/load.php?lang=fr&modules=ext.centralNotice.choiceData%2Cdisplay%2CgeoIP%2CkvStore%2CstartUp%7Cext.centralauth.ForeignApi%7Cext.centralauth.centralautologin.clearcookie%7Cext.cite.ux-enhancements%7Cext.cx.entrypoints.contributionsmenu%7Cext.cx.eventlogging.campaigns%7Cext.cx.widgets.callout%7Cext.echo.api%2Cinit%7Cext.eventLogging%2Ckartographer%2CnavigationTiming%2Cpopups%2CwikimediaEvents%7Cext.growthExperiments.SuggestedEditSession%7Cext.kartographer.box%2Cdata%2Csite%2Cstyle%2Cutil%7Cext.kartographer.lib.topojson%7Cext.uls.common%2Ccompactlinks%2Cinit%2Cinterface%2Cpreferences%2Cwebfonts%7Cjquery%2Cmapbox%2Coojs%2Coojs-router%2Coojs-ui%2Coojs-ui-core%2Coojs-ui-toolbars%2Coojs-ui-widgets%2Coojs-ui-windows%2Csite%7Cjquery.client%2Ccookie%2Ctablesorter%2CtextSelection%7Cjquery.uls.data%7Cmediawiki.ForeignApi%2CString%2CTitle%2CUri%2Capi%2Cbase%2Ccldr%2Ccookie%2Cexperiments%2CjqueryMsg%2Clanguage%2Cstorage%2Ctoc%2Cuser%2Cutil%7Cmediawiki.ForeignApi.core%7Cmediawiki.editfont.styles%7Cmediawiki.language.months%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.page.watch.ajax%7Cmediawiki.ui.button%2Cicon%7Cmmv.bootstrap%2Chead%7Cmmv.bootstrap.autostart%7Coojs-ui-core.icons%2Cstyles%7Coojs-ui-toolbars.icons%7Coojs-ui-widgets.icons%7Coojs-ui-windows.icons%7Coojs-ui.styles.icons-media%2Cindicators%7Cskins.vector.legacy.js%7Cuser.defaults&skin=vector&version=158p2

Related Objects

Event Timeline

Jdlrobson created this task.Jun 16 2020, 9:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 16 2020, 9:11 PM
thcipriani moved this task from Untriaged to Jun 2020 on the Wikimedia-production-error board.Jun 17 2020, 6:52 PM
Krinkle renamed this task from TypeError: rects is null to TypeError: rects is null (from VE FindAndReplaceDialog).Jul 22 2020, 7:39 PM
Jdlrobson added a comment.Aug 4 2020, 4:26 PM

An error with a similar stack trace sometimes reports itself as Uncaught TypeError: Cannot read property 'length' of null
https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2020.08.04/clienterror/?id=AXO6Sa_uNoG2jwpw2I83

Umherirrender added a project: JavaScript.Aug 5 2020, 10:09 PM
• matmarex closed this task as a duplicate of T261522: Uncaught TypeError: Cannot read property 'length' of null, TypeError: null is not an object (evaluating 'rects.length').Sep 10 2020, 6:56 PM
Jdlrobson reopened this task as Open.EditedSep 22 2020, 3:42 AM
Jdlrobson updated the task description. (Show Details)

This still seems to be occuring and my understanding is that the fix for T261522 is in production now? (Apologies if I've misunderstood something)

https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2020.09.21/clienterror/?id=AXSyC-siE5thwF5rMSpx

JTannerWMF added a project: Editing-team (Kanban Board).Sep 22 2020, 3:32 PM
JTannerWMF moved this task from To Triage to Triaged on the VisualEditor board.
JTannerWMF moved this task from Inbox to Doing on the Editing-team (Kanban Board) board.
• matmarex subscribed.Sep 22 2020, 8:24 PM

Chart for "rects is null": https://logstash.wikimedia.org/goto/91e5fcdf5bd39363519d06086f659b0e

image.png (1×2 px, 88 KB)

Looks like the errors disappeared between 2020-09-09 and 2020-09-16, then reappeared. So the first fix worked, then https://gerrit.wikimedia.org/r/626476 regressed the issue.

Very similar chart for "Cannot read property 'length' of null": https://logstash.wikimedia.org/goto/5a0da0e3d8cf553a614442893d8145ff (there is more noise, there are probably other errors with the same message)

image.png (1×2 px, 93 KB)

I'll merge this back into T261522 and reopen that one instead.

• matmarex closed this task as a duplicate of T261522: Uncaught TypeError: Cannot read property 'length' of null, TypeError: null is not an object (evaluating 'rects.length').Sep 22 2020, 8:24 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits