Sorry toast doesn't show for mobile editor on pages you can't edit (Uncaught TypeError: m.show is not a function, Uncaught TypeError: Cannot read property 'show' of undefined)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Jun 16 2020, 10:34 PM

Description

These account for the majority of errors that show up in logstash and are obscuring many other errors. Given that I think we should prioritize identifying and fixing or at the very least handling the error more gracefully. I suspect this may also be related to the large amount of errors we currently see logged in WebClientError.

https://logstash.wikimedia.org/goto/a04196f9b5e466d5a4ea82ebaa442bb2

The error is showing up in various forms about 610 a day on mediawiki.org (likely much higher on bigger wikis)

Details

	Subject	Repo	Branch	Lines +/-
	self.hide is not a function	mediawiki/extensions/Echo	master	+5 -4
	m.show is not a function	mediawiki/extensions/MobileFrontend	master	+4 -5

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		ovasileva	T254488 Identify top mobile error rate contributors
		Resolved		Jdlrobson	T255630 Sorry toast doesn't show for mobile editor on pages you can't edit (Uncaught TypeError: m.show is not a function, Uncaught TypeError: Cannot read property 'show' of undefined)

Event Timeline

Jdlrobson created this task.Jun 16 2020, 10:34 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 16 2020, 10:34 PM

Jdlrobson triaged this task as High priority.Jun 16 2020, 10:41 PM

Jdlrobson added a parent task: T254488: Identify top mobile error rate contributors.

Jdlrobson renamed this task from Uncaught TypeError: m.show is not a function, self.hide is not a function, Uncaught TypeError: Cannot read property 'show' of undefined to Sorry toast doesn't show for mobile editor on pages you can't edit (Uncaught TypeError: m.show is not a function, Uncaught TypeError: Cannot read property 'show' of undefined).Jun 17 2020, 9:41 PM

Change 606275 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] m.show is not a function

https://gerrit.wikimedia.org/r/606275

m.show points to MobileFrontend. In the dist that's equivalent to:

s.on("click",(function(t){m.show(e),t.preventDefault()})),t.route(f,(function(){m.show(e)})),

which points to src/mobile.init/editor.js
Meaning that when editing is disabled, the sorry toast is not showing.

The hide issue is: T253045

gerritbot added a project: Patch-For-Review.Jun 17 2020, 9:42 PM

Change 606277 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/Echo@master] self.hide is not a function

https://gerrit.wikimedia.org/r/606277

Change 606275 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] m.show is not a function

https://gerrit.wikimedia.org/r/606275

Change 606277 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] self.hide is not a function

https://gerrit.wikimedia.org/r/606277

I can QA this when it hits production.

Maintenance_bot removed a project: Patch-For-Review.Jun 17 2020, 11:10 PM

No more errors in production logged in the last 24hrs w00t!

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJun 26 2020, 4:13 PM

Sorry toast doesn't show for mobile editor on pages you can't edit (Uncaught TypeError: m.show is not a function, Uncaught TypeError: Cannot read property 'show' of undefined)Closed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

Sorry toast doesn't show for mobile editor on pages you can't edit (Uncaught TypeError: m.show is not a function, Uncaught TypeError: Cannot read property 'show' of undefined)
Closed, ResolvedPublic
Actions

Related Objects
Search...