Page MenuHomePhabricator

Internal error in Cargo Drilldown page when using Full-text search
Closed, ResolvedPublic

Description

Seeing this when using Full text search with any value but empty.

[f2b58641a4ec07cddc1363a8] /wiki/Special:Drilldown/entity_table?title=Special%3ADrilldown%2Fentity_table&_search=Welcome ArgumentCountError from line 46 of /opt/bitnami/apps/mediawiki/htdocs/includes/search/SearchDatabase.php: Too few arguments to function SearchDatabase::__construct(), 0 passed in /opt/bitnami/apps/mediawiki/htdocs/extensions/Cargo/includes/CargoSQLQuery.php on line 1463 and exactly 1 expected

Backtrace:

#0 /opt/bitnami/apps/mediawiki/htdocs/extensions/Cargo/includes/CargoSQLQuery.php(1463): SearchDatabase->__construct()
#1 /opt/bitnami/apps/mediawiki/htdocs/extensions/Cargo/includes/CargoSQLQuery.php(79): CargoSQLQuery->handleSearchTextFields()
#2 /opt/bitnami/apps/mediawiki/htdocs/extensions/Cargo/drilldown/CargoDrilldownPage.php(1974): CargoSQLQuery::newFromValues(string, string, string, string, string, NULL, string, integer, integer)
#3 /opt/bitnami/apps/mediawiki/htdocs/includes/specialpage/QueryPage.php(430): CargoDrilldownPage->getQueryInfo()
#4 /opt/bitnami/apps/mediawiki/htdocs/includes/specialpage/QueryPage.php(636): QueryPage->reallyDoQuery(integer, integer)
#5 /opt/bitnami/apps/mediawiki/htdocs/extensions/Cargo/drilldown/CargoSpecialDrilldown.php(284): QueryPage->execute(string)
#6 /opt/bitnami/apps/mediawiki/htdocs/includes/specialpage/SpecialPage.php(575): CargoSpecialDrilldown->execute(string)
#7 /opt/bitnami/apps/mediawiki/htdocs/includes/specialpage/SpecialPageFactory.php(611): SpecialPage->run(string)
#8 /opt/bitnami/apps/mediawiki/htdocs/includes/MediaWiki.php(296): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#9 /opt/bitnami/apps/mediawiki/htdocs/includes/MediaWiki.php(900): MediaWiki->performRequest()
#10 /opt/bitnami/apps/mediawiki/htdocs/includes/MediaWiki.php(527): MediaWiki->main()
#11 /opt/bitnami/apps/mediawiki/htdocs/index.php(44): MediaWiki->run()
#12 {main}

Event Timeline

Somehow no one noticed this before... it seems to happen with MW 1.34+. I just checked in what I think is a fix for this; please get the latest code and try it out, if you can.

Works now, thank you!